After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681228 - unify use of redefined {v}snprintf
unify use of redefined {v}snprintf
Status: RESOLVED FIXED
Product: libxml2
Classification: Platform
Component: general
git master
Other Windows
: Normal enhancement
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-05 11:48 UTC by Roumen Petrov
Modified: 2012-08-28 15:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
1 - The patch remove #Ifdef HAVE_CONFIG_H left only in regression test binaries (3.26 KB, patch)
2012-08-05 11:48 UTC, Roumen Petrov 		none Details | Review
2 - Clean redefinition of {v}snprintf in C-source (2.67 KB, patch)
2012-08-05 11:50 UTC, Roumen Petrov 		none Details | Review

Description Roumen Petrov 2012-08-05 11:48:48 UTC 
Created attachment 220356 [details] [review]
1 - The patch remove #Ifdef HAVE_CONFIG_H left only in regression test binaries

This is an enhancement request follow up issue #676427 (" use mingw C99 compatible functions {v}snprintf instead those from MSVC runtime).

Proposed patch was posted for review in libxml mail list here:
- https://mail.gnome.org/archives/xml/2012-May/msg00090.html 
with positive feedback :
- https://mail.gnome.org/archives/xml/2012-June/msg00009.html

Patch is split into two files.
Comment 1 Roumen Petrov 2012-08-05 11:50:21 UTC 
Created attachment 220357 [details] [review]
2 - Clean redefinition of {v}snprintf in C-source

Attached second part of the patch.
Comment 2 Daniel Veillard 2012-08-28 15:36:56 UTC 
I think everything to applied upstream now,

 thanks !

Daniel