After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681211 - info: assorted patches for the info panel
info: assorted patches for the info panel
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Other Preferences
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-04 21:23 UTC by Matthias Clasen
Modified: 2012-08-08 01:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
don't use GtkH/VBox (11.42 KB, patch)
2012-08-04 21:23 UTC, Matthias Clasen 		accepted-commit_now Details | Review
replace one GtkTable by GtkGrid (more to do) (3.69 KB, patch)
2012-08-04 21:24 UTC, Matthias Clasen 		accepted-commit_now Details | Review
fix one mnemonic (2.36 KB, patch)
2012-08-04 21:24 UTC, Matthias Clasen 		accepted-commit_now Details | Review
pick a better mnemonic (1.12 KB, patch)
2012-08-04 21:26 UTC, Matthias Clasen 		accepted-commit_now Details | Review
info: change 'other media action' mnemonic (1.16 KB, patch)
2012-08-08 01:56 UTC, Matthias Clasen 		committed Details | Review
info: Fix mnemonic activation for 'other media action' (2.40 KB, patch)
2012-08-08 01:56 UTC, Matthias Clasen 		committed Details | Review
info: replace one GtkTable instance by GtkGrid (3.74 KB, patch)
2012-08-08 01:56 UTC, Matthias Clasen 		committed Details | Review
info: Use GtkBox instead of GtkHBox/GtkVBox (11.46 KB, patch)
2012-08-08 01:56 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2012-08-04 21:23:11 UTC 
Some deprecation fixes, some keynav fixes
Comment 1 Matthias Clasen 2012-08-04 21:23:50 UTC 
Created attachment 220328 [details] [review]
don't use GtkH/VBox
Comment 2 Matthias Clasen 2012-08-04 21:24:17 UTC 
Created attachment 220329 [details] [review]
replace one GtkTable by GtkGrid (more to do)
Comment 3 Matthias Clasen 2012-08-04 21:24:41 UTC 
Created attachment 220330 [details] [review]
fix one mnemonic
Comment 4 Matthias Clasen 2012-08-04 21:26:02 UTC 
Created attachment 220331 [details] [review]
pick a better mnemonic
Comment 5 Bastien Nocera 2012-08-07 09:54:28 UTC 
Review of attachment 220328 [details] [review]:

Looks good.
Comment 6 Bastien Nocera 2012-08-07 09:55:28 UTC 
Review of attachment 220329 [details] [review]:

Looks good.
Comment 7 Bastien Nocera 2012-08-07 10:08:40 UTC 
Review of attachment 220330 [details] [review]:

Looks fine.
Comment 8 Bastien Nocera 2012-08-07 10:09:11 UTC 
Review of attachment 220331 [details] [review]:

Looks good.
Comment 9 Matthias Clasen 2012-08-08 01:55:52 UTC 
The following fixes have been pushed:
637bd51 info: change 'other media action' mnemonic
5fc4b18 info: Fix mnemonic activation for 'other media action'
34caef8 info: replace one GtkTable instance by GtkGrid
a8662e4 info: Use GtkBox instead of GtkHBox/GtkVBox
Comment 10 Matthias Clasen 2012-08-08 01:56:21 UTC 
The following fixes have been pushed:
637bd51 info: change 'other media action' mnemonic
5fc4b18 info: Fix mnemonic activation for 'other media action'
34caef8 info: replace one GtkTable instance by GtkGrid
a8662e4 info: Use GtkBox instead of GtkHBox/GtkVBox
Comment 11 Matthias Clasen 2012-08-08 01:56:24 UTC 
Created attachment 220623 [details] [review]
info: change 'other media action' mnemonic

Use the A instead of the o. There are no conflicts, and using
the first character as mnemonic is better.
Comment 12 Matthias Clasen 2012-08-08 01:56:26 UTC 
Created attachment 220624 [details] [review]
info: Fix mnemonic activation for 'other media action'

The mnemonic was pointing at a box, which is not activatable.
Comment 13 Matthias Clasen 2012-08-08 01:56:29 UTC 
Created attachment 220625 [details] [review]
info: replace one GtkTable instance by GtkGrid
Comment 14 Matthias Clasen 2012-08-08 01:56:31 UTC 
Created attachment 220626 [details] [review]
info: Use GtkBox instead of GtkHBox/GtkVBox