GNOME Bugzilla – Bug 681167
Fixes and improvements for the new theme for D-L
Last modified: 2012-09-30 15:38:54 UTC
Hello, I've made some fixes and improvements on Vinicius's theme for D-L, which are: - CSS fixes for Webkit browsers in table stats (epiphany still have some issues with gradients), - Minor fixes to homepage (added shadow under the text,same logo with wgo), - Improvements to module page (comment form and action boxes), - New icons taken from GNOME's HighContrast theme. - Added logout option to global domain bar. Brainstorming - Added the language selector to global domain bar (it's visible only to user settings page). You can find the pull request in github [1] and some screemshots in dropbox [2] (maybe upload the screens here?).Later on i'll post the patches corresponding to the changes. [1] https://github.com/vdepizzol/damned-lies/pull/1 [2] https://www.dropbox.com/s/zguid125qzuuwd7/dl.txt
You're too good to me, most of the things that bugged me when I looked at the older screenshots seems to be fixed! In short, amazing stuff! Here are some things that I spotted looking at the screenshots (will see if I can try it out in action also): * It would be great if we could have the global navigation we sport at the bottom of all the other pages such as www.gnome.org, git.gnome.org, mail.gnome.org etc. so it's easy to navigate between all the different subsites. * The user box looks less elegant than the one we have on https://extensions.gnome.org/ . At some point we've been talking about having a single sign-on system for all of gnome.org, so it would be great if these could look the same from the start. * Purple url:s on red bottom is hard to read, so I would go for something like #ffffff here. (https://www.dropbox.com/s/bc9ip3cknh2zmda/module-trans.png) * Would it be possible to get gravatar support like we have on extensions.gnome.org? None of these are really blocking I think, but nice-to-haves.
(In reply to comment #1) > You're too good to me, most of the things that bugged me when I looked at the > older screenshots seems to be fixed! > In short, amazing stuff! I'm glad you like it!! > * It would be great if we could have the global navigation we sport at the > bottom of all the other pages such as www.gnome.org, git.gnome.org, > mail.gnome.org etc. so it's easy to navigate between all the different > subsites. This could be easily done by changing the CSS code for the navbar. > * The user box looks less elegant than the one we have on > https://extensions.gnome.org/ . At some point we've been talking about having a > single sign-on system for all of gnome.org, so it would be great if these could > look the same from the start. I agree with you.At first i tried to get the same result but my lack of knowledge for django stopped me. Someone has to write an auth app,or get it from extensions.g.o and make it work for l10n or edit the current code and make it possible. For the logout i used the onclick event from javascript to submit the logout form,which is not the best solution (e.g. in user settings page if you want to logout you can't, because it doesn't work there!). In my opinion auth and global domain bar is an issue for the new theme.. > * Purple url:s on red bottom is hard to read, so I would go for something like > #ffffff here. (https://www.dropbox.com/s/bc9ip3cknh2zmda/module-trans.png) Hah,that's the only thing i didn't touch.It has a FIXME tag in the code and i left it. But sure we can fix this by removing the red background and maybe adding a download icon on the left. (as it is now). > * Would it be possible to get gravatar support like we have on > extensions.gnome.org? I'll try it,but unfortunately i can't guarantee that it will work.
Gravatar support is pretty easy, I can help with that Tom, could you attach to this bug the patch for integrate it in our newtheme branch? Thanks
Created attachment 220339 [details] [review] New icons and backup the old ones
Created attachment 220340 [details] [review] homepages changes Logo from w.g.o Shadow under the text Log out option Language change on global domain bar
Created attachment 220341 [details] [review] vertimus changes
Created attachment 220342 [details] [review] changes to user settings
Created attachment 220343 [details] [review] various CSS fixes
Created attachment 220344 [details] [review] logout to global domain bar This patch adds these 3 options to topbar. https://www.dropbox.com/s/t8weq3q2awljyyi/topbar.png
I created the patches from theses commits [1]. [1] https://github.com/vdepizzol/damned-lies/pull/1/commits The patches are a messy right now,because some of them add additional changes to other things.So if needed,give me some time to rework the commits and create new patches
Created attachment 220444 [details] [review] Homepage changes for D-L theme
Created attachment 220580 [details] [review] Same footer like other GNOME pages
Created attachment 220608 [details] [review] Global navigation for damned-lies Screenshot: https://www.dropbox.com/s/zcddfgn13f6kq7m/globalnav.png
Great work on the theming Tom! I will try it locally and rebase it to current master if you want.
Created attachment 220650 [details] [review] New icons for D-L theme
Created attachment 220651 [details] [review] Module page changes
Created attachment 220652 [details] [review] Fixes in stats table for various pages
Hello i reworked the patches for the theme and i left out the logout & language options that were on the global domain bar ('logout to global domain bar' patch is broken so i'll make it obsolete). Gil if you want i can push the changes as i have write-access to git for the translations.
(In reply to comment #18) > Hello i reworked the patches for the theme and i left out the logout & language > options that were on the global domain bar ('logout to global domain bar' patch > is broken so i'll make it obsolete). Great to hear that! > Gil if you want i can push the changes as i have write-access to git for the > translations. Push them to either a new branch or on top of the existing newtheme branch: http://git.gnome.org/browse/damned-lies/log/?h=newtheme
I pushed them to newtheme branch.
Great work Tom! How do you want us to give feedback on things that should be changed, need to be fixed? @Andreas, anyone from web/design team could be appointed to review and shake the design? I'm more than happy on helping in whichever way to make this happen soonish rather than late :)
Thank you Gil !! You can contact me at <tomtryf AT SPAMFREE gmail DOT com>, or CC me to a bug,or if this bug remains open make a comment here. I am also working on various minor fixes that i missed out,e.g. - CSS bug to module statistics bar,even if the module is fully translated there's a grey gap in the end, - stats table for 'Web' doesn't look good, - 'languages' and 'modules' pages need some work for WebKit browsers, - fixes to 'people' and 'about' pages, - some changes i forgot to apply (to global navbar,download button and vertimus module page), - something else i may notice :-)
(In reply to comment #21) > Great work Tom! > Very much agree! Excellent stuff! > @Andreas, anyone from web/design team could be appointed to review and shake > the design? Sure, I'm happy to review this. How do I test it out? I guess I can ping you on IRC about.
(In reply to comment #23) > > @Andreas, anyone from web/design team could be appointed to review and shake > > the design? > > Sure, I'm happy to review this. How do I test it out? I guess I can ping you on > IRC about. Quite easy actually, just install django on your system and then follow this 6 steps: http://git.gnome.org/browse/damned-lies/tree/README And then just browse around on http://localhost:8000
Hello, Could you please help me to decide which one of the two styles to use (for po statistics) ? Screenshots: https://www.dropbox.com/s/pj3g16q07nvwnaa/module_1.png https://www.dropbox.com/s/neg0t8qadx07gix/module_2.png (po reduced)
Created attachment 221250 [details] [review] Fixes for various pages Fixes: - Quick links in about page, - Download button, - Module's statistics bar, - Person page improvements (change details & password pages too), - Improvements to edit pages for modules and teams, - Improvements to activity summary page, - Improvements to language/modules/teams pages Is it ok to push the commit ? Screenshots: https://www.dropbox.com/sh/8qlkcvrh4h8jblj/nBe0EDPdoQ#/
For me it's fine. I'm looking forward to see the result. Gil?
Looks really good indeed! Is everything pushed on the newtheme branch? I see some space not filled (on the right corner) on the progress bars which looks a bit broken. Also the underline on the statistics looks also a bit out of place. Anyway, it's a huuuuge improvement over what we currently have, I'm usually more in the bandwagon of "release early, release often", so I would say to merge the branch and let's fix the details as soon as translators see them, but I would like an ack from the design team (@Andreas?) to say if it's ok to push that. Tom, you are my hero!!
I pushed the last patch which fixes the progress bar.About the underline we can remove it. Also it would be nice to review the theme and fix any bugs we may find. In my opinion the login/logout options need work on the global domain bar.One temporary solution is to replace the submit button with an image until someone port(?) the sign-on system from https://extensions.gnome.org/
(In reply to comment #30) > I pushed the last patch which fixes the progress bar.About the underline we can > remove it. Great work man! If you were to ask me about the underline, yes, I would remove it, but let's wait until the design team says something about it. > Also it would be nice to review the theme and fix any bugs we may find. Yep, that's what I'm not 100% for merging to master and updating the website and on top of that I would like the web design team to take a look at it, maybe they want to change colors or some layouts etc.. > In my opinion the login/logout options need work on the global domain bar.One > temporary solution is to replace the submit button with an image until someone > port(?) the sign-on system from https://extensions.gnome.org/ I will go for our in-house solution and file a bug for extensions.gnome.org to generalize their sign-on system. It will take a while to do so, if done at all.
Hi, folks. I think is a good time to resolve this bug too: https://bugzilla.gnome.org/show_bug.cgi?id=608280 And about the pot file download? Is it really necessary? It's cause confusion. Maybe it can be removed from module page. -- Adorilson
(In reply to comment #32) > Hi, folks. > > I think is a good time to resolve this bug too: > https://bugzilla.gnome.org/show_bug.cgi?id=608280 > > And about the pot file download? > Is it really necessary? > It's cause confusion. Maybe it can be removed from module page. > > -- > Adorilson In general I agree on that bug, the whole detailed view of a po file is currently too cluttered somehow. Still, I would first ask the designers about their ideas on it :) But definitely a cleanup of that interface, at some point (code and ideas welcome ;) is needed
Adding #669926 as being blocked by this one. We could try to add a class to images so that Andre can do its own things and we can style them in some way (showing them in a pop-up for bigger images?)
GNOME 3.6 is out, so I will go ahead and merge it :) Let's file bugs for any annoyance on the new theme aside. Big thanks to Vinicius and Tom to make it happen!