GNOME Bugzilla – Bug 681132
Add SELinux checks
Last modified: 2016-03-31 14:01:59 UTC
There are still many users with invalid SELinux context. Let's try to help them figure out. For now, this will only by run with --checks, but we should probably consider adding a dialog, and eventually run the restorecon command if they agree to do so.
Created attachment 220238 [details] [review] util: teach exec to optionally return stdout and stderr
Created attachment 220239 [details] [review] util: add check_selinux_context_default Add a check for SELinux context
Created attachment 220240 [details] [review] main: make --checks looks a big prettier - add leading • for each checks - add report bug and home page links
Created attachment 220247 [details] [review] main: make --checks looks a bit prettier - add leading • for each checks - add report bug and home page links
Review of attachment 220238 [details] [review]: Looks good otherwise. ::: src/util.vala @@ -467,2 +473,2 @@ yield run_in_thread (() => { - exec_sync (argv); + exec_sync (argv, out std_output, out std_error); why not just pass the out params directly here?
Review of attachment 220239 [details] [review]: Looks good. ACK if you have tested it against both failing and successful cases.
Review of attachment 220247 [details] [review]: Looks good otherwise. ::: src/wizard.vala @@ +199,2 @@ source.save (); + App.app.add_collection_source.begin (source); Is this and other similar change related to this patch?
Review of attachment 220238 [details] [review]: ::: src/util.vala @@ -467,2 +473,2 @@ yield run_in_thread (() => { - exec_sync (argv); + exec_sync (argv, out std_output, out std_error); because of bug https://bugzilla.gnome.org/show_bug.cgi?id=681136
Review of attachment 220247 [details] [review]: ::: src/wizard.vala @@ +199,2 @@ source.save (); + App.app.add_collection_source.begin (source); ah right, I was wondering where that change went, sorry it should be seperate.
(In reply to comment #9) > Review of attachment 220238 [details] [review]: > > ::: src/util.vala > @@ -467,2 +473,2 @@ > yield run_in_thread (() => { > - exec_sync (argv); > + exec_sync (argv, out std_output, out std_error); > > because of bug https://bugzilla.gnome.org/show_bug.cgi?id=681136 Fair enough, please add a FIXME note there pointing to this bug so we remember to remove this workaround when that bug is fixed.
Attachment 220238 [details] pushed as a894d50 - util: teach exec to optionally return stdout and stderr Attachment 220239 [details] pushed as 50e4efa - util: add check_selinux_context_default Attachment 220247 [details] pushed as abeb4a2 - main: make --checks looks a bit prettier