After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681078 - e-web-view: use GtkOrientable API for password bar
e-web-view: use GtkOrientable API for password bar
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-02 15:16 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2012-08-03 09:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
e-web-view: use GtkOrientable API for password bar (2.28 KB, patch)
2012-08-02 15:16 UTC, Diego Escalante Urrelo (not reading bugmail) 		accepted-commit_now Details | Review
e-web-view: use GtkOrientable API for info bars (4.26 KB, patch)
2012-08-02 15:35 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2012-08-02 15:16:08 UTC 
Save some code, yeah.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2012-08-02 15:16:11 UTC 
Created attachment 220160 [details] [review]
e-web-view: use GtkOrientable API for password bar

Instead of creating a custom GtkButtonBox, use GtkOrientable API
implemented by the default action_area widget (a GtkBox) of GtkInfoBar.
Comment 2 Xan Lopez 2012-08-02 15:19:26 UTC 
Review of attachment 220160 [details] [review]:

OK.
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-08-02 15:35:54 UTC 
Created attachment 220161 [details] [review]
e-web-view: use GtkOrientable API for info bars

Instead of creating a custom GtkButtonBox, use GtkOrientable API
implemented by the default action_area widget (a GtkBox) of GtkInfoBar.

==

Noticed that there was the geoclue infobar which also does the old
hackish thing.
Comment 4 Xan Lopez 2012-08-02 22:58:26 UTC 
Review of attachment 220161 [details] [review]:

OK again.
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2012-08-03 08:55:20 UTC 
Attachment 220161 [details] pushed as f62663b - e-web-view: use GtkOrientable API for info bars