GNOME Bugzilla – Bug 681019
Make Clocks translatable
Last modified: 2012-08-16 16:07:17 UTC
Currently there is no /po subdirectory to translate Clocks to other languages. See https://live.gnome.org/TranslationProject/DevGuidelines/ for how-to and common pitfalls.
Created attachment 221209 [details] [review] Add trnaslation support to gnome-clocks Here is a basic but functionnal translation patch. I plan to write scripts to help generate .pot, /po and .mo files. Also i would like to have your opinion on where and how to install .mo files when gnome-clock is installed on the system (right now it look inside gnome-clocks directory, but it's straightforward to change that).
Comment on attachment 221209 [details] [review] Add trnaslation support to gnome-clocks Hi Lavault, thanks for the patch! Note that we don't add .mo files to the code repository - they are normally created when compiling. We only put .po files into the repository. Also you don't need to write scripts for creating pot or po files - this all exists already (for example "intltool-update --pot") so save your time and have some icecream instead! :) I'd prefer to have the fr_FR translation in a separate patch/commit, and translation files should normally be in a subfolder called "po" (instead of locale), like for example /po/cz.po /po/fr.po .
Created attachment 221270 [details] [review] Add translation support to gnome-clocks Ok thanks for the review ! I'm not familiar with best practices in gnome project. I know there are utilities to do so, i use them to create po, pot and mo files. But IMHO it's quite a pain to have to type 3 not so short commands every time there is a small change. I made the changes you suggested, here are new patches !
Created attachment 221271 [details] [review] Add French translation to gnome-clocks
I also added translation support in the patchset on bug #681883
Created attachment 221406 [details] [review] Cleaner gettext approach, some new strings marked as translatable Here is a patch against new master.
Comment on attachment 221270 [details] [review] Add translation support to gnome-clocks I am marking this as obsolete since part of the support has been committed and the remaining changes are in your updated patch below. Next time remember to tick the "obsoletes ..." checkbox when updating a patch
Review of attachment 221406 [details] [review]: The patch looks good to me. I think it should be applied
Comment on attachment 221406 [details] [review] Cleaner gettext approach, some new strings marked as translatable The patch looks good to me. I think it should be applied
Committed the patch, the translation and regenerated the .pot file. Thanks!