After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681010 - assertion `WEBKIT_IS_NETWORK_RESPONSE(response)' failed
assertion `WEBKIT_IS_NETWORK_RESPONSE(response)' failed
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-01 17:52 UTC by Claudio Saavedra
Modified: 2012-08-02 08:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
popup-commands: don't cancel a start that hasn't even been started (887 bytes, patch)
2012-08-02 08:12 UTC, Claudio Saavedra 		committed Details | Review

Description Claudio Saavedra 2012-08-01 17:52:43 UTC 
1. Open whatever bugzilla bug
2. Right-click on an attachment, save link as...
3. Cancel the file chooser, boom!

** (epiphany:20186): CRITICAL **: SoupMessage* webkit_network_response_get_message(WebKitNetworkResponse*): assertion `WEBKIT_IS_NETWORK_RESPONSE(response)' failed
Comment 1 Xan Lopez 2012-08-01 18:16:58 UTC 
Right, as theorized in bug #674291 this is just broken. I think doing what we said there makes sense.
Comment 2 Claudio Saavedra 2012-08-02 08:02:17 UTC 
Looking at the code, it actually looks like cancelling the dialog triggers a call to webkit_download_cancel() even when webkit_download_start() is not called at all. While starting the download before showing the dialog would probably solve this, I think this is a slightly different issue to fix.
Comment 3 Claudio Saavedra 2012-08-02 08:04:08 UTC 
For reference:

+ Trace 230616

  • #0 g_logv
    at gmessages.c line 758
  • #1 g_log
    at gmessages.c line 792
  • #2 g_return_if_fail_warning
  • #3 webkit_network_response_get_message
    from /opt/gnome-3.0/lib64/libwebkitgtk-3.0.so.0
  • #4 WebKit::core(_WebKitNetworkResponse*)
    from /opt/gnome-3.0/lib64/libwebkitgtk-3.0.so.0
  • #5 webkit_download_cancel
    from /opt/gnome-3.0/lib64/libwebkitgtk-3.0.so.0
  • #6 ephy_download_cancel
    at ephy-download.c line 629
  • #7 response_cb
    at popup-commands.c line 206
  • #8 g_cclosure_marshal_VOID__INT
    at gmarshal.c line 372
  • #9 g_closure_invoke
    at gclosure.c line 777
  • #10 signal_emit_unlocked_R
    at gsignal.c line 3551
  • #11 g_signal_emit_valist
    at gsignal.c line 3300
  • #12 g_signal_emit
    at gsignal.c line 3356
  • #13 gtk_dialog_response
    at gtkdialog.c line 948
  • #14 gtk_dialog_delete_event_handler
    at gtkdialog.c line 441 






Comment 4


Claudio Saavedra





          2012-08-02 08:12:06 UTC
        



Created attachment 220121 [details] [review]
popup-commands: don't cancel a start that hasn't even been started

Cancelling the "save link as" dialog is calling ephy_download_cancel()
even when ephy_download_start() has not been called. This causes a
critical warning in webkit.






Comment 5


Claudio Saavedra





          2012-08-02 08:12:54 UTC
        



s/start/download :)






Comment 6


Xan Lopez





          2012-08-02 08:51:27 UTC
        



Review of attachment 220121 [details] [review]:

OK, but we should really do the other thing :)






Comment 7


Claudio Saavedra





          2012-08-02 08:54:21 UTC
        



One step at the time!! :)