After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680925 - build: Fix parallel build problems with enum generation
build: Fix parallel build problems with enum generation
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2012-07-31 17:14 UTC by Ross Burton
Modified: 2012-08-14 17:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Fix parallel build problems with enum generation (9.21 KB, patch)
2012-07-31 17:14 UTC, Ross Burton
accepted-commit_now Details | Review

Description Ross Burton 2012-07-31 17:14:53 UTC
If the enum rule is triggered because one of the dependencies changed, but the
resulting enum-types file is identical, it isn't copied across.  This causes
problems in parallel builds because make busy-loops on the file changing instead
of just running the commands sequentially.

The upshot is that a make -j where this happens (simply touching a .h file will
do it) will sit spinning inside make.

Fix this by pruning the dependencies to only those actually required, and doing
a mv instead of cmp||cp.  If the headers have been modified then we'll be
rebuilding anyway so the optimisation of the cmp is simply causing bugs.
Comment 1 Ross Burton 2012-07-31 17:14:55 UTC
Created attachment 220004 [details] [review]
build: Fix parallel build problems with enum generation
Comment 2 Paolo Bacchilega 2012-07-31 20:18:26 UTC
Comment on attachment 220004 [details] [review]
build: Fix parallel build problems with enum generation

patch pushed to master, thank you.