After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680863 - Won't build from git without udisk2 version >= 1.97
Won't build from git without udisk2 version >= 1.97
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: build
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
: 680864 680865 680866 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-07-30 18:39 UTC by Chris Kühl
Modified: 2012-07-31 09:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Require version 1.97 of udisks2 (978 bytes, patch)
2012-07-30 18:39 UTC, Chris Kühl 		committed Details | Review

Description Chris Kühl 2012-07-30 18:39:48 UTC 
Created attachment 219927 [details] [review]
Require version 1.97 of udisks2

On gets the error listed below when building with udisks 1.94 for example.

gvfs_udisks2_volume_monitor-gvfsudisks2volume.o: In function `update_volume':
/home/chris/checkout/gnome/gvfs/monitor/udisks2/gvfsudisks2volume.c:229: undefined reference to `udisks_client_get_loop_for_block'
/home/chris/checkout/gnome/gvfs/monitor/udisks2/gvfsudisks2volume.c:367: undefined reference to `udisks_loop_get_setup_by_uid'
gvfs_udisks2_volume_monitor-gvfsudisks2volume.o: In function `ensure_autoclear':
/home/chris/checkout/gnome/gvfs/monitor/udisks2/gvfsudisks2volume.c:912: undefined reference to `udisks_client_get_loop_for_block'
/home/chris/checkout/gnome/gvfs/monitor/udisks2/gvfsudisks2volume.c:916: undefined reference to `udisks_loop_get_autoclear'
/home/chris/checkout/gnome/gvfs/monitor/udisks2/gvfsudisks2volume.c:916: undefined reference to `udisks_loop_get_setup_by_uid'
/home/chris/checkout/gnome/gvfs/monitor/udisks2/gvfsudisks2volume.c:919: undefined reference to `udisks_loop_call_set_autoclear'
collect2: error: ld returned 1 exit status

The attached patch should require the correct version.
Comment 1 Tomas Bzatek 2012-07-31 09:20:24 UTC 
*** Bug 680864 has been marked as a duplicate of this bug. ***
Comment 2 Tomas Bzatek 2012-07-31 09:20:32 UTC 
*** Bug 680865 has been marked as a duplicate of this bug. ***
Comment 3 Tomas Bzatek 2012-07-31 09:20:41 UTC 
*** Bug 680866 has been marked as a duplicate of this bug. ***
Comment 4 Tomas Bzatek 2012-07-31 09:34:34 UTC 
Agreed, distributors are not even shipping older udisks2 versions since it's considered still in development. Requiring 1.97 is a reasonable requirement for now.

commit 76bbf5cfc3d98c2e6cbcf17d21f7900c9e28935a
Author: Chris Kühl <blixtra@gmail.com>
Date:   Tue Jul 31 11:21:37 2012 +0200

    build: Update udisks2 requirement to version 1.97
    
    The use of udisks_loop_get_setup_by_uid,
    udisks_client_get_loop_for_block, udisks_loop_get_autoclear,
    udisks_loop_get_setup_by_uid, & udisks_loop_call_set_autoclear in
    gvfsudisks2volume.c cause the build to fail without a udisks2 version
    >= 1.97.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=680863
    
    Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>


I've also removed unnecessary checks:

commit a494b809eaf82994108bfbbe5d950fed1a0a8c7c
Author: Tomas Bzatek <tbzatek@redhat.com>
Date:   Tue Jul 31 11:32:37 2012 +0200

    udisks2: Remove UDISKS_CHECK_VERSION ifdefs since we require 1.97 now