GNOME Bugzilla – Bug 680851
Asynchronously select/launch machines
Last modified: 2016-03-31 13:54:03 UTC
Currently user doesn't see any activity for at least a few seconds (actual time varies but can easily be up to several seconds for local VMs) after clicking on a box. Attaching patches to fix that.
Created attachment 219912 [details] [review] machine: Asynchronously select/launch machines W/o this patch, user doesn't see any activity for at least a few seconds (actual time varies but can easily be up to several seconds for local VMs) after clicking on a box. Also remove some redundant return values.
Created attachment 219913 [details] [review] Simplify LibvirtMachine.connect_display() This should probably be squashed into parent commit: 'machine: Asynchronously select/launch machines'.
Created attachment 219959 [details] [review] app: Remove a redundant return value
Created attachment 219960 [details] [review] machine: Asynchronously launch machines W/o this patch, user doesn't see any activity for at least a few seconds (actual time varies but can easily be up to several seconds for local VMs) after clicking on a box.
(In reply to comment #4) > Created an attachment (id=219960) [details] [review] > machine: Asynchronously launch machines This requires my pending 'Add async variant of gvir_domain_resume()' patch to libvirt-glib.
Created attachment 220567 [details] [review] app: Remove a redundant return value V2: Rebased on git master
Created attachment 220568 [details] [review] machine: Asynchronously launch machines V2: Rebased on git master
(In reply to comment #6) > Created an attachment (id=220567) [details] [review] > app: Remove a redundant return value > > V2: Rebased on git master the idea is rather to return true if the VM can be successfully opened. Not sure it's worth this change here.. ack anyway...
(In reply to comment #7) > Created an attachment (id=220568) [details] [review] > machine: Asynchronously launch machines > > V2: Rebased on git master maybe you need to change libvirt-glib version check?
(In reply to comment #8) > (In reply to comment #6) > > Created an attachment (id=220567) [details] [review] [details] [review] > > app: Remove a redundant return value > > > > V2: Rebased on git master > > the idea is rather to return true if the VM can be successfully opened. Not > sure it's worth this change here.. ack anyway... I know the idea but it wasn't really being used and this change made implemetning the following change, easier. (In reply to comment #9) > (In reply to comment #7) > > Created an attachment (id=220568) [details] [review] [details] [review] > > machine: Asynchronously launch machines > > > > V2: Rebased on git master > > maybe you need to change libvirt-glib version check? You already did that for me. :)
(In reply to comment #10) > You already did that for me. :) ah, it failed to compile here. if only we would have more precise git version checks.. rebuilding the whole stuff again..
(In reply to comment #11) > (In reply to comment #10) > > You already did that for me. :) > > ah, it failed to compile here. if only we would have more precise git version > checks.. rebuilding the whole stuff again.. OK my bad. Totally forgot to push the needed libvirt-glib patch and now I need to bump the required version again..
Review of attachment 220568 [details] [review]: ack
Review of attachment 220568 [details] [review]: please bump libvirt-glib version check
Review of attachment 220567 [details] [review]: ack
Attachment 220567 [details] pushed as baa61f7 - app: Remove a redundant return value Attachment 220568 [details] pushed as 27c02d8 - machine: Asynchronously launch machines