After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680842 - preferences: don't free consumed floating GVariant
preferences: don't free consumed floating GVariant
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-30 15:09 UTC by Allison Karlitskaya (desrt)
Modified: 2012-08-01 08:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
preferences: don't free consumed floating GVariant (892 bytes, patch)
2012-07-30 15:09 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2012-07-30 15:09:18 UTC 
See patch.
Comment 1 Allison Karlitskaya (desrt) 2012-07-30 15:09:20 UTC 
Created attachment 219899 [details] [review]
preferences: don't free consumed floating GVariant

g_variant_builder_end() returns a floating reference and
g_settings_set_value() consumes it, so we should not unref it again.
Comment 2 Jonathan Matthew 2012-07-30 21:37:11 UTC 
Review of attachment 219899 [details] [review]:

sure.
Comment 3 Allison Karlitskaya (desrt) 2012-08-01 08:06:17 UTC 
Attachment 219899 [details] pushed as 0a3cb15 - preferences: don't free consumed floating GVariant