After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680778 - Stop using empathy-accounts
Stop using empathy-accounts
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: UOA
2.33.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-29 10:10 UTC by Guillaume Desmottes
Modified: 2013-06-09 18:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
factor out launch_empathy_accounts() (1.29 KB, patch)
2012-08-03 12:52 UTC, Guillaume Desmottes
none Details | Review
start_external_app: fix critical warning message (941 bytes, patch)
2012-08-03 12:52 UTC, Guillaume Desmottes
none Details | Review
factor out empathy_launch_external_app() (3.77 KB, patch)
2012-08-03 12:52 UTC, Guillaume Desmottes
none Details | Review
empathy_launch_external_app: allow to pass arguments (5.13 KB, patch)
2012-08-03 12:52 UTC, Guillaume Desmottes
none Details | Review
use empathy_launch_external_app() to launch gnome-contacts (3.17 KB, patch)
2012-08-03 12:52 UTC, Guillaume Desmottes
none Details | Review
accounts-dialog: invoke the UOA panel if needed (3.07 KB, patch)
2012-08-03 12:52 UTC, Guillaume Desmottes
none Details | Review

Description Guillaume Desmottes 2012-07-29 10:10:12 UTC
If UOA support has been enabled, we should launch the UOA panel instead of empathy-accounts.
Comment 1 Guillaume Desmottes 2012-08-03 12:52:24 UTC
Created attachment 220232 [details] [review]
factor out launch_empathy_accounts()
Comment 2 Guillaume Desmottes 2012-08-03 12:52:27 UTC
Created attachment 220233 [details] [review]
start_external_app: fix critical warning message
Comment 3 Guillaume Desmottes 2012-08-03 12:52:29 UTC
Created attachment 220234 [details] [review]
factor out empathy_launch_external_app()
Comment 4 Guillaume Desmottes 2012-08-03 12:52:32 UTC
Created attachment 220235 [details] [review]
empathy_launch_external_app: allow to pass arguments
Comment 5 Guillaume Desmottes 2012-08-03 12:52:35 UTC
Created attachment 220236 [details] [review]
use empathy_launch_external_app() to launch gnome-contacts
Comment 6 Guillaume Desmottes 2012-08-03 12:52:38 UTC
Created attachment 220237 [details] [review]
accounts-dialog: invoke the UOA panel if needed
Comment 7 Xavier Claessens 2012-08-15 12:39:04 UTC
Review of attachment 220237 [details] [review]:

::: src/empathy-accounts-dialog.c
@@ +2668,3 @@
+  TpAccountManager *manager;
+
+  if (if_needed)

hidden I think.
Comment 8 Xavier Claessens 2012-08-15 12:39:24 UTC
Fixed the typo and merged.
Comment 9 Jeremy Bicha 2013-06-09 18:17:09 UTC
This patch isn't quite correct. See bug 701903 for details.