After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680773 - Misc fixes for new wireless panel
Misc fixes for new wireless panel
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-29 09:43 UTC by Cosimo Cecchi
Modified: 2012-07-29 10:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
network: add a shadow to the wireless scrolled window (930 bytes, patch)
2012-07-29 09:43 UTC, Cosimo Cecchi
committed Details | Review
network: don't set 'dim-label' in the <packing> section (1.41 KB, patch)
2012-07-29 09:43 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2012-07-29 09:43:27 UTC
See attaches patches
Comment 1 Cosimo Cecchi 2012-07-29 09:43:29 UTC
Created attachment 219815 [details] [review]
network: add a shadow to the wireless scrolled window
Comment 2 Cosimo Cecchi 2012-07-29 09:43:35 UTC
Created attachment 219816 [details] [review]
network: don't set 'dim-label' in the <packing> section

It should be set among the normal properties.
Comment 3 Matthias Clasen 2012-07-29 10:15:01 UTC
Review of attachment 219815 [details] [review]:

Looks good to me
Comment 4 Matthias Clasen 2012-07-29 10:15:19 UTC
Review of attachment 219816 [details] [review]:

I had the same fix here locally, +1
Comment 5 Cosimo Cecchi 2012-07-29 10:17:23 UTC
Attachment 219815 [details] pushed as 2ad1d54 - network: add a shadow to the wireless scrolled window
Attachment 219816 [details] pushed as 5b1491b - network: don't set 'dim-label' in the <packing> section

Pushed to master.