GNOME Bugzilla – Bug 680759
Syntax error in Gio _propertySetter
Last modified: 2012-09-06 15:04:32 UTC
hi, I am working on the prefs tool for my gnome-shell extension (put window), The user is able to store application based config in the settings schema. After saving the chances i show a gtk.messagebox. At this point the whole shell freezes (sometimes) and must be restart from tty1 by killing the old shell and start a new one. (gnome-shell --replace doesn't work). Today i found a interesing log message on my tty. JS Error: must pass a single parameter to log the error occures inside a catch-block in modules/overrides/Gio.js#_propertySetter (around line 150) http://git.gnome.org/browse/gjs/tree/modules/overrides/Gio.js?id=96977af3512f9af7a778230a632e847c83b10679 Line #153 should be this.g_object_path + '. Error is ' + e.message); but is this.g_object_path, '. Error is ' + e.message); Looks like this bug exists in all branches on git.gnome.org. cheers
Created attachment 220258 [details] [review] Gio: fix a typo in an error path log must only be called with one argument. At the same time, improve the log message to be in the usual "prefix: message" format.
Review of attachment 220258 [details] [review]: Looks good.
Attachment 220258 [details] pushed as d6227ca - Gio: fix a typo in an error path Toh. I hadn't noticed this was reviewed.