GNOME Bugzilla – Bug 680724
attachments bar regression
Last modified: 2013-09-13 01:08:47 UTC
in git/master, the attachments bar regressed (was fine in 3.5.4 and before). I can unfold the attachments bar (pane?), it expends and i see all the expected pieces. When I fold it back, the pieces disappear as expected but the pane doesn't shrink back to its original folded size (it just blanks itself). If i then scroll (with the mousewheel) in the preview pane, it messes every up (the bar reappears partly over the headers). that's with webkitgtk 1.9.2 on ubuntu.
not sure if it's related but i sometimes see some logs in the console: (evolution:30742): Gtk-WARNING **: EAttachmentBar 0xb96c0198 is mapped but not visible (evolution:30742): Gtk-WARNING **: EAttachmentBar 0xb96c0198 is mapped but not visible (evolution:30742): Gtk-WARNING **: EAttachmentBar 0xb96c0198 is mapped but visible=0 child_visible=1 parent GtkBox 0xb9999cd0 mapped=1 (evolution:30742): Gtk-WARNING **: EAttachmentBar 0xb96c0198 is mapped but not visible (evolution:30742): Gtk-WARNING **: EAttachmentBar 0xb96c0198 is mapped but visible=0 child_visible=1 parent GtkBox 0xb9999cd0 mapped=1 those don't seem to happen when i touch the attachments bar though.
Created attachment 219873 [details] [review] Fix I apologize to EAttachmentBar for calling it a liar. Anyway, I can't see the Gtk warnings with WebKit 1.8.x. Are the warnings still there with this patch? Could you get a backtrace of them (first you need to find out what action triggers the warnings and then set breakpoint to g_logv function and try to reproduce the warning).
I just tried with WebKit 1.9.5 and haven't seen any Gtk warnings.
Created attachment 219922 [details] backtrace Here is the backtrace for the first EAttachmentBar Gtk-WARNING.
Also, with your patch in #c2, the initial problem is gone. Good, or almost.. The attachments bar is now usable, except when the window is not wide enough to show all the attachments in one line and wraps on two. Then, the bar content is misplaced (too high), it covers the email headers and its own bar controls, so there's no way to fold the attachments bar back. I can reproduce easily on my 23" screen; starting with evo fullscreen showing an email with 8 attachments (1 line in the unfolded bar), and by resizing evo to be narrower.
Untested, but looks fine. Please commit. Thanks.
Comment on attachment 219873 [details] [review] Fix Committed to git master as a661dfe http://git.gnome.org/browse/evolution/commit/?id=a661dfebc6e3c5daeb7cf9bf3492eae989c4f590
The issue described in comment #5 was reported in bug #681431, Fabien please CC yourself there, I'll close this as fixed and will post a patch for the other issue to the new bug.