After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680683 - Do not block factory's main thread
Do not block factory's main thread
Status: RESOLVED FIXED
Product: evolution-ews
Classification: Other
Component: Calendar
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Evolution EWS maintainer(s)
Evolution EWS maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-07-27 06:30 UTC by Milan Crha
Modified: 2012-07-27 08:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ews patch (1.44 KB, patch)
2012-07-27 08:33 UTC, Milan Crha
committed Details | Review

Description Milan Crha 2012-07-27 06:30:02 UTC
Moving this from a downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=843684

EWS can block factory's main thread, like within ews_start_sync() while waiting for a lock, which is held by other thread(s), causing other factory callers timeout. These g_idle_add()/g_timeout_add() should run its own threads, instead of blocking factory's main thread.
Comment 1 Milan Crha 2012-07-27 08:33:34 UTC
Created attachment 219724 [details] [review]
ews patch

for evolution-ews;

I thought there will be more places which would be good to fix, but there was only this one. The other g_idle_add*/g_timeout_add* are irrelevant.
Comment 2 Milan Crha 2012-07-27 08:35:35 UTC
Created commit e8a5eae in ews master (3.5.5+)
Created commit a2d6bc4 in ews gnome-3-4 (3.4.4+)