After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680646 - UOA: Web authentificated accounts shouldn't be modifiable
UOA: Web authentificated accounts shouldn't be modifiable
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-26 13:16 UTC by Xavier Claessens
Modified: 2012-07-26 13:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
UOA mc-plugin: CANNOT_SET_PARAMETERS depends on account's settings (2.23 KB, patch)
2012-07-26 13:17 UTC, Xavier Claessens 		reviewed Details | Review
Accounts dialog: use external app for readonly UOA accounts (1.52 KB, patch)
2012-07-26 13:17 UTC, Xavier Claessens 		reviewed Details | Review

Description Xavier Claessens 2012-07-26 13:16:33 UTC 
The profile has a special key telling if the params are read-only or not. Use it.
Comment 2 Xavier Claessens 2012-07-26 13:17:20 UTC 
Created attachment 219688 [details] [review]
UOA mc-plugin: CANNOT_SET_PARAMETERS depends on account's settings

A special key has been added in .service files of online accounts
telling its args should be considered readonly. Generic accounts (e.g. AIM)
can still be modified.
Comment 3 Xavier Claessens 2012-07-26 13:17:24 UTC 
Created attachment 219689 [details] [review]
Accounts dialog: use external app for readonly UOA accounts
Comment 4 Guillaume Desmottes 2012-07-26 13:18:33 UTC 
Review of attachment 219688 [details] [review]:

::: ubuntu-online-accounts/mc-plugin/mcp-account-manager-uoa.c
@@ +710,3 @@
+  McpAccountManagerUoa *self = (McpAccountManagerUoa *) storage;
+  AgAccountService *service;
+  guint restrictions = 0;

init to CANNOT_SET_SERVICE ?
Comment 5 Guillaume Desmottes 2012-07-26 13:19:54 UTC 
Review of attachment 219689 [details] [review]:

Maybe worth cherry-picking this patch from my WIP branch first? http://cgit.collabora.com/git/user/cassidy/empathy/commit/?h=external&id=b56a0fc3dd2e14d55352f51e667093d1117aad43
Comment 6 Xavier Claessens 2012-07-26 13:26:59 UTC 
ok, done that and merged in master (with your commit). Thanks.