After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680539 - runtests does not use pthreads support for various Unix platforms
runtests does not use pthreads support for various Unix platforms
Status: RESOLVED FIXED
Product: libxml2
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-24 17:21 UTC by Daniel Richard G.
Modified: 2012-08-07 02:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed fix (3.18 KB, patch)
2012-07-24 17:21 UTC, Daniel Richard G.
none Details | Review

Description Daniel Richard G. 2012-07-24 17:21:34 UTC
Created attachment 219592 [details] [review]
Proposed fix

The runtests program currently fails with

    Specific platform thread support not detected

on HP-UX, AIX and other Unix systems which do not match the conditional

    #if defined(linux) || defined(__sun) || defined(__APPLE_CC__)

It is silly to try to enumerate all systems which use pthreads in a conditional like this. I am attaching a patch (against git master) that rewrites the cpp conditional structure so that pthreads is used if HAVE_PTHREAD_H is defined, and moves that section of code down below the Win32 and BeOS cases so that native thread libraries are used preferentially in those two cases.
Comment 1 Daniel Veillard 2012-08-07 02:19:25 UTC
Okay, looks correct, pushed to git !

 thanks !

Daniel