GNOME Bugzilla – Bug 680425
Port to gstreamer 1.0
Last modified: 2012-08-10 13:39:43 UTC
See https://live.gnome.org/GnomeGoals/PortToGstreamer1
Created attachment 219923 [details] [review] Port to GStreamer 1.0 - completely untested
Created attachment 219924 [details] [review] Port to GStreamer 1.0 - completely untested (this time against master not 3.4 branch) Previous patch was for gnome-3-4 branch.
Also worth noting that this is against GStreamer git master, the patch uses API that is not in the last pre-releases yet (0.11.92), namely gst_tag_list_get_sample_index(). There should be new pre-releases soon.
Review of attachment 219924 [details] [review]: Thanks, looks pretty good to me (but I haven't tested either). I just have two very small comments below. ::: src/Makefile-sushi.am @@ +88,3 @@ + --includedir=`$(PKG_CONFIG) --variable=girdir gstreamer-base-1.0` \ + --includedir=`$(PKG_CONFIG) --variable=girdir gstreamer-pbutils-1.0` \ + --add-include-path=`$(PKG_CONFIG) --variable=girdir gstreamer-tag-1.0` Please indent this with spaces instead of tabs - why are this additions needed here in any case? ::: src/Makefile.am @@ +50,3 @@ $(SUSHI_LIBS) sushi_start_CPPFLAGS = \ + -DGST_USE_UNSTABLE_API \ Same here
Created attachment 219985 [details] [review] Updated patch according to comments. Still untested. Thanks for the review. Fixed up tabs to spaces in Makefile.am > why are [these Makefile.am g-i] additions needed here in any case? To make the g-ir-scanner etc. find the Gst-1.0.gir files in an uninstalled GStreamer setup (which is what I and most GStreamer hackers use for development). But I imagine they would also be needed if GStreamer was installed into a prefix different from the rest of most of the system.
Unfortunately it seems to crash inside gstreamer, with the following trace: (gdb) bt
+ Trace 230636
Hrm, what are the other threads doing then? Do you get the same crash with gst-launch-1.0 playbin uri=file:///path/to/foo ? Is this with git master of GStreamer ? Are there any warnings/criticals before it crashes? Is there a way for me try and reproduce this by running some test binary from the sushi source directory (without installing it)?
Tested this again with all the gstreamer modules updated to git master, and it seems to work fine indeed now! I pushed it to git master, thanks a lot for the patch!