GNOME Bugzilla – Bug 680368
Port spell checking feature to WebKit2
Last modified: 2012-08-09 17:47:44 UTC
We need specific API in WebKit2 to implement this in ephy. Work is already ongoing in that front. See WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=90268
Created attachment 220419 [details] [review] Path proposal Now that the associated WebKit bug has been fixed [1], we can propose a simple patch to port this feature to ephy+wk2 :-) [1] https://bugs.webkit.org/show_bug.cgi?id=90268
Review of attachment 220419 [details] [review]: Cool! I suppose this just shows up automagically in our menus with WK2? ::: embed/ephy-embed-prefs.c @@ +536,3 @@ + web_context = webkit_web_context_get_default (); + webkit_web_context_set_spell_checking_enabled(web_context, value); + webkit_web_context_set_spell_checking_languages(web_context, langs); Missing spaces after ( here.
(In reply to comment #2) > Review of attachment 220419 [details] [review]: > > Cool! I suppose this just shows up automagically in our menus with WK2? Yes. It uses the same "Enable spell checking" checkbox + list of languages in the preferences dialog ('Languages' tab) than for WK1. > ::: embed/ephy-embed-prefs.c > @@ +536,3 @@ > + web_context = webkit_web_context_get_default (); > + webkit_web_context_set_spell_checking_enabled(web_context, value); > + webkit_web_context_set_spell_checking_languages(web_context, langs); > > Missing spaces after ( here. Crap. Blame WK's coding style for that :)
Comment on attachment 220419 [details] [review] Path proposal This was committed as 20261c39.
Closing.
Argh! I forgot resolving this bug when committing. Sorry about that!