GNOME Bugzilla – Bug 680340
unable to monitor access time changes
Last modified: 2018-05-24 14:22:47 UTC
Nautilus displays access time in various places in the interface. These values are often a lie because we don't get any information from GIO about changes. The inotify code seems to explicitly ignore IN_ACCESS events.
Created attachment 219347 [details] [review] Add ability to monitor access time changes Interpret them as attribute changes which seems reasonable since access time is retrieved as an attribute in the API.
don't most filesystems get mounted with noatime anyway?
At least on Fedora the default is to use relatime.
access time is a complete disaster... particularly considering it gets update when you do something as innocent as content-type identification...
Can you give examples what what you mean? GIO already gets file_info using O_NOATIME.
It seems that some thumbnailers do not, then. Of course, we could try to patch all of those up as well...
Yep. See bug 680326.
Created attachment 219382 [details] [review] Add ability to monitor access time changes Changed to add a new event type that most apps probably won't handle by default. Using a changed type event made it too easy to get into cycles.
Created attachment 219385 [details] [review] Add ability to monitor access time changes After more testing I don't think even that was enough. Too many clients are interpreting the "changed" signal, unsurprisingly, to mean the file was changed. It might be better to add a separate signal for accessed.
Review of attachment 219385 [details] [review]: ::: gio/inotify/inotify-path.c @@ +36,3 @@ #include "inotify-missing.h" +#define IP_INOTIFY_MASK (IN_ACCESS|IN_MODIFY|IN_ATTRIB|IN_MOVED_FROM|IN_MOVED_TO|IN_DELETE|IN_CREATE|IN_DELETE_SELF|IN_UNMOUNT|IN_MOVE_SELF|IN_CLOSE_WRITE) I have a pretty big problem with this part of the patch. We now turn every single case of file change monitoring into file access monitoring (in terms of effect on the kernel and number of process wakeups). This would definitely need to be done on an opt-in basis... I still question the usefulness of atime in general...
Created attachment 219387 [details] [review] Add ability to monitor access time changes Small update. Need to put the new signal in the reserved area.
It would be better to add a flag to opt in to atime notifications. like bug 532815
Can't we just delete access time from the Nautilus user interface?
(In reply to comment #13) > Can't we just delete access time from the Nautilus user interface? atime is used for other things, see the related bugs.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/576.