GNOME Bugzilla – Bug 680339
Allow notes
Last modified: 2013-11-21 14:55:13 UTC
Notes give a way for a developer to "clear the error" on an erroneous commit that has already been commited to version control. Right now, we disallow all ref types that aren't branches or tags. This commit enable notes ref types as well.
Created attachment 219345 [details] [review] Allow notes
Note, attachment 219345 [details] [review] is untested, since it's kind of hard for me get a setup to test it. It's just a copy-and-paste of the banch reftype code with changes that I think make sense for notes. Backstory is I fouled up this commit: http://git.gnome.org/browse/gdm/commit/?id=e7b3beb03459fd6b5b774694f7e0bb8fc5e58716 to have two commits in it and didn't notice before pushing. I wanted there to be a note in the log so I did "git notes add HEAD" and then added a message explaining the details of my mistake, and then proceded to push the note only to get greeted with: remote: --- remote: You are trying to push the ref: remote: remote: refs/notes/commits remote: remote: to git.gnome.org. This is not a branch or tag. remote: --- To ssh://halfline@git.gnome.org/git/gdm ! [remote rejected] refs/notes/commits -> refs/notes/commits (pre-receive hook declined) error: failed to push some refs to 'ssh://halfline@git.gnome.org/git/gdm'
Review of attachment 219345 [details] [review]: Where I wrote "clear the error" I meant "clear the air"
The GNOME Infrastructure Team is currently migrating its bug / issue tracker away from Bugzilla to Request Tracker and therefore all the currently open bugs have been closed and marked as OBSOLETE. The following move will also act as a cleanup for very old and ancient tickets that were still living on Bugzilla. If your issue still hasn't been fixed as of today please report it again on the relevant RT queue. More details about the available queues you can report the bug against can be found at https://wiki.gnome.org/Sysadmin/RequestTracker. Thanks for your patience, the GNOME Infrastructure Team