After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680256 - GnomeWallClock: add ignore-date property
GnomeWallClock: add ignore-date property
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
unspecified
Other All
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks: 619955
 
 
Reported: 2012-07-19 14:42 UTC by Giovanni Campagna
Modified: 2012-07-20 00:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GnomeWallClock: add ignore-date property (3.22 KB, patch)
2012-07-19 14:42 UTC, Giovanni Campagna
none Details | Review
GnomeWallClock: add ignore-date property (5.04 KB, patch)
2012-07-19 15:04 UTC, Giovanni Campagna
reviewed Details | Review
GnomeWallClock: add ignore-date property (5.04 KB, patch)
2012-07-19 16:15 UTC, Giovanni Campagna
reviewed Details | Review
GnomeWallClock: add ignore-date property (5.05 KB, patch)
2012-07-19 23:24 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2012-07-19 14:42:45 UTC
In certain cases (such as the gnome-shell lock screen) we want
to show a clock without a date. This allows that, without duplicating
logic.
Comment 1 Giovanni Campagna 2012-07-19 14:42:47 UTC
Created attachment 219234 [details] [review]
GnomeWallClock: add ignore-date property
Comment 2 Giovanni Campagna 2012-07-19 15:04:34 UTC
Created attachment 219237 [details] [review]
GnomeWallClock: add ignore-date property

In certain cases (such as the gnome-shell lock screen) we want
to show a clock without a date. This allows that, without duplicating
logic.

Previous fix was too quick and too dirty. This one works.
Comment 3 Colin Walters 2012-07-19 15:36:28 UTC
Review of attachment 219237 [details] [review]:

::: libgnome-desktop/gnome-wall-clock.c
@@ +238,3 @@
 			format_string = show_seconds ? _("%a %b %e, %R:%S")
 				: _("%a %b %e, %R");
+		} else if (show_date) {

Err...ok so reading this I was really confused because I don't think of the day of the week as part of the "date", and you're making this distinction between "full date" and "date".

I think it would be way, way clearer to call the option "show_time_only" or "show_clock_only".
Comment 4 Giovanni Campagna 2012-07-19 16:15:37 UTC
Created attachment 219246 [details] [review]
GnomeWallClock: add ignore-date property

In certain cases (such as the gnome-shell lock screen) we want
to show a clock without a date. This allows that, without duplicating
logic.

Second try.
Comment 5 Colin Walters 2012-07-19 22:14:02 UTC
Review of attachment 219246 [details] [review]:

This looks unchanged from the previous one?  Did you forget to "git commit -a --amend"?  Or were you not intending to address my comment?
Comment 6 Giovanni Campagna 2012-07-19 23:24:51 UTC
Created attachment 219282 [details] [review]
GnomeWallClock: add ignore-date property

In certain cases (such as the gnome-shell lock screen) we want
to show a clock without a date. This allows that, without duplicating
logic.

Sorry, yeah, I forgot to amend the commit...
Comment 7 Colin Walters 2012-07-19 23:50:22 UTC
Review of attachment 219282 [details] [review]:

Looks better, thanks!
Comment 8 Giovanni Campagna 2012-07-20 00:00:56 UTC
Attachment 219282 [details] pushed as e5b7e53 - GnomeWallClock: add ignore-date property