GNOME Bugzilla – Bug 680231
Inconsistent screen lock behavior in gnome-shell and gnome-settings-deamon
Last modified: 2012-08-16 18:58:34 UTC
If the lid-close behavior is set to "Suspend", g-s-d checks whether gnome-screensaver is lock-enabled before suspending the system. However, the suspend button in gnome-shell always locks the screen before suspending. So, if the user disables the screen lock in control-center, then the behavior will be inconsistent.
Created attachment 220644 [details] [review] gsd patch to always lock the screen on sleep The quick hack simply removes the "lock-enabled" check in gnome-settings-daemon, so that gnome-shell and g-s-d always lock the screen before suspending. I did a quick search and found no guideline about the screen-lock behavior (just about the UI design). Any opinion?
Hmm...isn't a bug in gnome-shell that we're not respecting lock-enabled before suspend?
Because I don't know what is the expected behavior, either locking the screen always or depending on the screensaver settings.
Created attachment 221076 [details] [review] UserMenu: don't lock the screen if automatic lock disabled If automatic lock is disabled in the control center, only lock when explicitly using the Lock menu item, and not for Suspend or Switch user/session. A possible patch to address this, from the other point of view.
Review of attachment 221076 [details] [review]: Sure.
Comment on attachment 221076 [details] [review] UserMenu: don't lock the screen if automatic lock disabled Nope, it doesn't work...
Ok, actually it almost works. Pushing as it solves the Suspend problem, see the dependent bug for Switch user.
Comment on attachment 221076 [details] [review] UserMenu: don't lock the screen if automatic lock disabled Attachment 221076 [details] pushed as 06262a9 - UserMenu: don't lock the screen if automatic lock disabled
Created attachment 221168 [details] [review] Use GDM instead of libaccountsservice for fast user switching libaccountsservice uses gdmflexiserver internally, which has been removed from gdm. Instead, use libgdm directly.
Review of attachment 221168 [details] [review]: Fix libaccountsservice?
(In reply to comment #10) > Review of attachment 221168 [details] [review]: > > Fix libaccountsservice? Is it right for libaccountsservice to depend on libgdm? The accountsservice is a freedesktop project, and is shared by different DMs (AFAIK)
I'm going to be removing the session stuff in libaccountsservice, so this is correct.
Review of attachment 221168 [details] [review]: Good.
Attachment 221168 [details] pushed as 1dbbb4f - Use GDM instead of libaccountsservice for fast user switching I'd say this is finally fixed now.