After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680228 - In Thunderbird 14.0 e-mail address auto completion results are not spoken
In Thunderbird 14.0 e-mail address auto completion results are not spoken
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: Orca Maintainers
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-19 06:51 UTC by Hammer Attila
Modified: 2012-10-16 13:04 UTC
See Also:
GNOME target: ---
GNOME version: 3.3/3.4


Attachments
Debug file with perhaps why happening this problem (199.60 KB, application/octet-stream)
2012-07-19 06:51 UTC, Hammer Attila
Details
Result the fix (227.32 KB, application/octet-stream)
2012-10-16 07:17 UTC, Hammer Attila
Details

Description Hammer Attila 2012-07-19 06:51:27 UTC
Created attachment 219198 [details]
Debug file with perhaps why happening this problem

Since My Ubuntu 12.04 system Thunderbird upgraded with latest 14.0 release, Orca doesn't spokening e-mail address auto completion result if an e-mail address added the address book.
Reproducation steps:
1. Launch Thunderbird.
2. PRESS CTRL+N keystroke.
3. Begin typing an e-mail address with added the address book. Braille display the full e-mail address seeing, but Orca doesn't spokening the completed e-mail address.
This problem I experienced with Orca 3.4.2, but Orca 3.5 latest gnome-3-6 branch version the problem reproducable.
Milton, and José confirmed this problem in orca-list.

I attaching the debug.out file.

Attila
Comment 1 Hammer Attila 2012-07-19 06:55:16 UTC
I forgot write prewious:
Autocompleted e-mail address Orca spokening only when I press TAB key and go to the subject line.


Attila
Comment 2 Diana Huang 2012-10-06 15:32:28 UTC
As part of the GHC 2012 Open Source Day, I have confirmed this bug is occurring, and I do see this Accerciser event monitor output (removing the actual e-mail address and name for privacy reasons):

object:text-changed:insert(0, 1, j)
	source: [entry | To:]
	application: [application | Thunderbird]
object:text-changed:insert(1, 37, XXXX XXXX <XXXXX@gmail.com>)
	source: [entry | To:]
	application: [application | Thunderbird]
object:text-selection-changed(0, 0, )
	source: [entry | To:]
	application: [application | Thunderbird]
object:text-changed:insert(0, 38, XXXX XXXX <XXXXX@gmail.com>)
	source: [entry | To:]
	application: [application | Thunderbird]

In all likelihood, these events are being filtered incorrectly.
Comment 3 Hammer Attila 2012-10-07 05:48:43 UTC
Very interesting, if I using Orca where am I command after auto completion, I partialy hear the selected autocompleted e-mail address related informations in the to: field. Only problem is Orca when begin spokening the selected e-mail address related informations cut the first three character the speech output.
If I this situation press CTRL+A keystroke and use where am I command again, I full hear the autocompleted e-mail address related information (name and e-mail address).

Attila
Comment 4 Joanmarie Diggs (IRC: joanie) 2012-10-15 15:23:41 UTC
Aha.

It appears that the folks at Mozilla cannot get the ':system' suffix right to save their lives. First they put it on everything causing Orca to not echo characters; now they have removed it from the autocomplete -- where it belongs because autocompleted text is added by the system.

Given that Mozilla seems to see us (and Thunderbird) as a low priority, I'll try to hack around this.
Comment 5 Hammer Attila 2012-10-15 15:53:54 UTC
Many many thanks Joanie if possible fix this problem in Orca level the gnome-3-6 branch and master branch.
If this is impossible Orca level, you will be report this problem in bugzilla.mozilla.org?
Yes, with Mozilla unfortunately Thunderbird have low priority, for example not fixed yet the broken accessible hierarchy in Thunderbird message filters dialog related bug (bug number is 737101). This bug resulting unfortunately screen reader user impossible to set up a folder when want creating message filter rule.

Attila
Comment 6 Joanmarie Diggs (IRC: joanie) 2012-10-15 16:05:25 UTC
(In reply to comment #5)
> Many many thanks Joanie if possible fix this problem in Orca level the
> gnome-3-6 branch and master branch.
> If this is impossible Orca level, you will be report this problem in
> bugzilla.mozilla.org?

I'm afraid if I report it -- assuming they actually try to fix it -- they'll just do it wrong. (This current bug seems to be an overfix of the earlier "system" suffix bug that took them forever to fix.)

Anyhoo.... In this particular case, the sad hack was easy and safe (targeted to a very specific area in the Thunderbird script). So, yes, I did fix it in both the gnome-3-6 branch and master.

master: http://git.gnome.org/browse/orca/commit/?id=34e4b8c1a6204af8b24ea2365f6130b1fe3527b0

gnome-3-6: http://git.gnome.org/browse/orca/commit/?h=gnome-3-6&id=79b2dadef2ddd8b92b954c748d62d53dac630593
Comment 7 Hammer Attila 2012-10-16 07:17:18 UTC
Created attachment 226525 [details]
Result the fix

Hy Joanie,

I unfortunately not general way tested the committed fix, because I want testing speech and braille affecting the committed fix.
Because in Quantal braille support entire not working if I using Orca (this is not Orca developers mistake), I applied the gnome-3-6 fix into gnome-3-4 branch of Orca. Not elegant way this, but the fix possible testing my local separated testing Ubuntu 12.04 system without I risk my production work system.
I attaching a debug.out file, because I have following test result:
1. Speech support the auto completion works great again.
2. With braille support when I begin typing an e-mail address, only the typed characters presented my braille display. For example I typed me character, auto complete completed the e-mail address with Mesar Hameed e-mail address, but other part the e-mail address I don't see the braille display until I not move back a character with left arrow key. The caret prewious land right after the > simbol before I moved left a character.

Without the fix, speech support auto completion not working of course, but braille presenting right the auto completed e-mail address after I typed the me characters without need manual moving the caret. This situation I entire see braille display the auto completed e-mail address, and braille cursor lands right after the > character.

Possible fix anyway the braille part, or need keeping this fix until Mozilla developers not fixing this bug in Thunderbird? Speech support works wonderful after your commit, so this is an important fix with speech support users.
I very sorry to I not possible testing the committed fixes with legal way with newest GNOME and newest Orca releases. I think Brltty part Python3 bindings is missing in Quantal, Liblouis Python3 bindings missing because Ubuntu developers will be not upgraded 2.4.1 Liblouis version to 2.5.1 version. Ubuntu developers migrated in Quantal with Python3 and ship with Orca 3.7.0.93-0ubuntu1 version without packaging importanter dependencies, so this is a horror now. :-(:-(

Attila
Attila
Comment 8 Joanmarie Diggs (IRC: joanie) 2012-10-16 09:34:24 UTC
Thanks for testing! As for the hack and the braille side effect, if you look at the patch, all it does is test differently now that the "system" suffix is absent. In other words, the braille issue presumably was there before Thunderbird 14 (or whatever version they broke the suffix).

I'll see what I can do.
Comment 9 Joanmarie Diggs (IRC: joanie) 2012-10-16 11:43:02 UTC
So the problem with the braille was that the autocomplete handling was returning rather than calling the Gecko script. The reason my speech fix seemed to break braille is that the autocomplete handling wasn't getting called before the fix and now is getting called.

Happily, the additional change is a one-liner:

master: http://git.gnome.org/browse/orca/commit/?id=b3553027a4d4bf7f93075b10b6d633a17a1a2358

gnome-3-6: http://git.gnome.org/browse/orca/commit/?h=gnome-3-6&id=b3ecd640924c1f60dd04a12226275fef16802e8a
Comment 10 Hammer Attila 2012-10-16 12:27:10 UTC
I tested my Ubuntu 12.04 testing system the change with gnome-3-4 branch, fix now works great. Both speech and braille I seeing right informations if autocomplete happening. Many thanks Joanie this fix, I get back full accessible auto complete support for Orca.

I have got a question, but you don't angry me please when reading remaining comment part:
Because Ubuntu 12.04 Lts release for example is a long term supported release, but Orca 3.6 version not possible to use this system the newest GTK3 and other components dependency requirements to users possible to use wonderful Orca 3.6 fixes, not possible to doing a 3.4.3 last maintenance release with containing importanter Orca 3.6 safe compatible fixes? I no why have this dependency requirement the Orca 3.6 release and full agree this step.
If your answer is this is possible, I try helping what fixes are possible putting the Orca 3.4.3 maintenance release with I already safe to using my Ubuntu 12.04 system day by day.
Own purpose I collected some patches from gnome-3-6 branch with I already using with Orca gnome-3-4 branch my system.
I absolute agree if you saying GNOME level not possible doing this step, but prewious this purpose have an orca-xdesktop branch when GNOME migrated with GSettings I think. I no, GNOME 3.4 series maintenance support is oldest time end, but this is a special situation.

Attila
Comment 11 Joanmarie Diggs (IRC: joanie) 2012-10-16 12:59:02 UTC
Thanks for testing!

I'm not going to get angry, Attila. Don't be silly. But I would suggest that you have Luke handle this:

* Ubuntu LTS is not upstream; it is downstream
* GNOME 3.6 is the current upstream stable version; GNOME 3.4 is not
* Luke is a Canonical employee and does Ubuntu accessibility packages

He can backport what he sees fit to LTS.
Comment 12 Hammer Attila 2012-10-16 13:04:21 UTC
Agree your answer Joanie.
I will be opening future a Launchpad.net bugreport this autocomplete problem related for Orca and will be attach the gnome-3-6 related joined patch. Very hope this fix will be backported into 3.4.

Attila