After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680221 - Port to GDBus and Gtk.Application
Port to GDBus and Gtk.Application
Status: RESOLVED FIXED
Product: sushi
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Sushi maintainer(s)
Sushi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-07-19 02:06 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-07-19 02:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
application: Port to GDBus (and Lang.Class) (2.76 KB, patch)
2012-07-19 02:06 UTC, Jasper St. Pierre (not reading bugmail) 		accepted-commit_now Details | Review
application: Port to Gtk.Application (2.33 KB, patch)
2012-07-19 02:06 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
application: Remove the Activate method, and the RemoteApplication proxy (1.91 KB, patch)
2012-07-19 02:22 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
application: Port to GDBus (and Lang.Class) (2.76 KB, patch)
2012-07-19 02:22 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
application: Port to Gtk.Application (2.33 KB, patch)
2012-07-19 02:22 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-07-19 02:06:30 UTC 
See patches.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-07-19 02:06:32 UTC 
Created attachment 219185 [details] [review]
application: Port to GDBus (and Lang.Class)
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-07-19 02:06:34 UTC 
Created attachment 219186 [details] [review]
application: Port to Gtk.Application
Comment 3 Cosimo Cecchi 2012-07-19 02:20:19 UTC 
Review of attachment 219185 [details] [review]:

Looks good, thanks!
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-07-19 02:22:28 UTC 
Created attachment 219190 [details] [review]
application: Remove the Activate method, and the RemoteApplication proxy

They do nothing.



Er, sorry, I forgot to attach the entire patch stack. Next two patches are same
as before, just repositioned.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-07-19 02:22:37 UTC 
Created attachment 219191 [details] [review]
application: Port to GDBus (and Lang.Class)
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-07-19 02:22:42 UTC 
Created attachment 219192 [details] [review]
application: Port to Gtk.Application
Comment 7 Cosimo Cecchi 2012-07-19 02:28:45 UTC 
Review of attachment 219190 [details] [review]:

Okay, good catch
Comment 8 Cosimo Cecchi 2012-07-19 02:29:19 UTC 
Review of attachment 219191 [details] [review]:

OK
Comment 9 Cosimo Cecchi 2012-07-19 02:29:40 UTC 
Review of attachment 219192 [details] [review]:

Yes
Comment 10 Jasper St. Pierre (not reading bugmail) 2012-07-19 02:30:50 UTC 
Attachment 219190 [details] pushed as 99170ff - application: Remove the Activate method, and the RemoteApplication proxy
Attachment 219191 [details] pushed as d1bf83c - application: Port to GDBus (and Lang.Class)
Attachment 219192 [details] pushed as 7e15fa6 - application: Port to Gtk.Application