After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680216 - Don't pass extra arguments to C functions
Don't pass extra arguments to C functions
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-19 00:31 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-07-19 15:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
js: Don't pass extra arguments to add_actor (6.69 KB, patch)
2012-07-19 00:31 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
js: Spurious fixes for cases where we pass extra arguments (872 bytes, patch)
2012-07-19 00:31 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-07-19 00:31:13 UTC 
See #680215 for details. Maybe we should make a common widget out
of the application list code...
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-07-19 00:31:15 UTC 
Created attachment 219177 [details] [review]
js: Don't pass extra arguments to add_actor

It's clear that this was supposed to be passed to our own 'add' monkey
patch, but we missed. Remove the ignored arguments.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-07-19 00:31:18 UTC 
Created attachment 219178 [details] [review]
js: Spurious fixes for cases where we pass extra arguments
Comment 3 Giovanni Campagna 2012-07-19 09:41:03 UTC 
Review of attachment 219177 [details] [review]:

Should the argument be removed, or should add_actor be replaced with add instead?
After all, there must have been a reason for that child properties to be added in the first place.
Comment 4 Giovanni Campagna 2012-07-19 09:41:39 UTC 
Review of attachment 219178 [details] [review]:

Ok
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-07-19 13:40:41 UTC 
(In reply to comment #3)
> Review of attachment 219177 [details] [review]:
> 
> Should the argument be removed, or should add_actor be replaced with add
> instead?
> After all, there must have been a reason for that child properties to be added
> in the first place.

I tried that at first, but it broke things.
Comment 6 Giovanni Campagna 2012-07-19 13:57:29 UTC 
Review of attachment 219177 [details] [review]:

Bah. ACN because the arguments were ignored anyway.
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-07-19 15:01:24 UTC 
Attachment 219177 [details] pushed as 19e4c95 - js: Don't pass extra arguments to add_actor
Attachment 219178 [details] pushed as dd80f39 - js: Spurious fixes for cases where we pass extra arguments