Created attachment 219097 [details] [review]
Keep "name" as a generic free-form base item text

Created attachment 219098 [details] [review]
Keep "name" as a generic free-form base item text

"title" should stay libvirt specific.

Now renaming a remote machine connection in properties update
properties topbar label correctly again.

Review of attachment 219098 [details] [review]:

::: src/collection-view.vala
@@ -239,3 @@
 
-            if (item_a == null || item_b == null) // FIXME?!
-                return 0;

I need to investigate why we have null values, meanwhile, not change this code..

Created attachment 219149 [details] [review]
Keep "name" as a generic free-form base item text

"title" should stay libvirt specific.

Now renaming a remote machine connection in properties update
properties topbar label correctly again.

Ok, once again trying to set the proper status on a patch just wastes my time, so a ACK in a comment will have to do.

Review of attachment 219149 [details] [review]:

Looks good otherewise.

::: src/libvirt-machine.vala
@@ +92,3 @@
                            GVir.Connection connection,
                            GVir.Domain     domain) throws GLib.Error {
+        var config = domain.get_config (0);

update_domain_config() call below does the same again which is why I wasn't doing this here. I suggest to just use domain name here as the Item.name and update it later if title is available after domain config is fetched.

(In reply to comment #6)
> +        var config = domain.get_config (0);
> 
> update_domain_config() call below does the same again which is why I wasn't
> doing this here. I suggest to just use domain name here as the Item.name and
> update it later if title is available after domain config is fetched.

Altough it is true that we call domain.get_config (0) twice after this patch, this is an intermediate change before introducing GVir.DomainXMLFlags.INACTIVE usage in the following patches I submitted for dealing with pending config.

Attachment 219149 [details] pushed as 149418d - Keep "name" as a generic free-form base item text