After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680160 - Auth client code should make easier to add other account storages
Auth client code should make easier to add other account storages
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Auth client
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-18 11:59 UTC by Xavier Claessens
Modified: 2012-07-18 12:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Move SASL mechanism implementations into its own file (22.34 KB, patch)
2012-07-18 12:26 UTC, Xavier Claessens 		none Details | Review
Implement Google X-OAUTH2 SASL mechanism (3.27 KB, patch)
2012-07-18 12:26 UTC, Xavier Claessens 		none Details | Review

Description Xavier Claessens 2012-07-18 11:59:28 UTC 
Atm all the SASL code is in the GOA-specific code. But other storages could require doing SASL dance as well.
Comment 1 Xavier Claessens 2012-07-18 12:00:12 UTC 
Here is a branch doing that: http://cgit.collabora.com/git/user/xclaesse/empathy.git/log/?h=auth-refactor

As bonus point, it implement the Google auth, even if not used (yet?) by GOA.
Comment 2 Guillaume Desmottes 2012-07-18 12:25:12 UTC 
++

You may want to amend commit messages to include an url to this bug.
Comment 3 Xavier Claessens 2012-07-18 12:26:39 UTC 
Created attachment 219093 [details] [review]
Move SASL mechanism implementations into its own file

We could have other account providers than GOA requiring
this SASL code.
Comment 4 Xavier Claessens 2012-07-18 12:26:43 UTC 
Created attachment 219094 [details] [review]
Implement Google X-OAUTH2 SASL mechanism
Comment 5 Xavier Claessens 2012-07-18 12:27:54 UTC 
Should have used git bz from the beginning, here it is :)

Merged.