GNOME Bugzilla – Bug 680152
build with libgee 0.8
Last modified: 2013-02-19 11:02:03 UTC
Making all in libempathy make[2]: Entering directory `/home/spider/Projects/gnome/empathy/libempathy' GEN empathy-enum-types.h make all-am make[3]: Entering directory `/home/spider/Projects/gnome/empathy/libempathy' CC empathy-contact.lo empathy-contact.c: In function 'empathy_contact_change_group': empathy-contact.c:929:11: warning: passing argument 4 of 'gee_hash_set_new' from incompatible pointer type [enabled by default] In file included from /opt/gnome/include/folks/folks.h:11:0, from empathy-contact.c:32: /opt/gnome/include/gee-0.8/gee.h:1335:13: note: expected 'GeeHashDataFunc' but argument is of type 'guint (*)(const void *)' empathy-contact.c:929:11: error: too few arguments to function 'gee_hash_set_new' In file included from /opt/gnome/include/folks/folks.h:11:0, from empathy-contact.c:32: /opt/gnome/include/gee-0.8/gee.h:1335:13: note: declared here make[3]: *** [empathy-contact.lo] Error 1 make[3]: Leaving directory `/home/spider/Projects/gnome/empathy/libempathy' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/spider/Projects/gnome/empathy/libempathy' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/spider/Projects/gnome/empathy' make: *** [all] Error 2 Name: libgee Module Set: gnome-suites-core-deps-3.6 Type: autogen Install version: 5d8d67044b415b31cda54ce0024a3db119518d00 Install date: 2012-07-18 12:37:27 Git Module: git://git.gnome.org/libgee Git Branch: master Tree-ID: 5d8d67044b415b31cda54ce0024a3db119518d00 Sourcedir: /home/spider/Projects/gnome/libgee Requires: glib, gobject-introspection, vala Required by: valadoc, folks Name: folks Module Set: gnome-suites-core-deps-3.6 Type: autogen Install version: dfa96f91fe046e39861a15a305cc05ef9c9bbc5c Install date: 2012-07-18 12:33:05 Git Module: git://git.gnome.org/folks Git Branch: master Tree-ID: dfa96f91fe046e39861a15a305cc05ef9c9bbc5c Sourcedir: /home/spider/Projects/gnome/folks Requires: dbus, dbus-glib, libgee, vala, gobject-introspection, telepathy-glib, evolution-data-server, libzeitgeist, shared-mime-info Required by: gnome-contacts, empathy Suggests: telepathy-logger
Created attachment 219150 [details] [review] Port empathy to libgee 0.8 libgee 0.8 breaks abi from 0.6, so some porting is needed. This patch fixes the build and seems to run ok here.
Created attachment 219160 [details] [review] gee_iterator_first is not available in libgee-0.8 This one seems required too (libempathy-gtk side of things, ie gee_iterator_first is missing).
(Empathy bug, not folks bug.)
You should bump version required in configure.ac I think. Otherwise, the patches looks good :)
Actually we weren't checking for gee in Empathy's configure. I'll fix that and merge the patches. Thanks!
Shouldn't this be reopened until libgee 0.8 is released?
Is libgee 0.8 still planned to be released before GNOME 3.6 ?
(In reply to comment #7) > Is libgee 0.8 still planned to be released before GNOME 3.6 ? From http://pastebin.com/hXZY3tgQ: 19-08-2012 23:10:51 < juergbi!~juerg@77-58-108-244.dclient.hispeed.ch: mpiechotka: btw: people were asking about libgee 0.8 and gnome 3.6 19-08-2012 23:10:58 < mpiechotka!~mpiechotk@c-69-181-160-249.hsd1.ca.comcast.net: juergbi: I just wanted to sync up releases (previously I make a rele ase just to have it broken next day) 19-08-2012 23:10:59 < juergbi!~juerg@77-58-108-244.dclient.hispeed.ch: what's the plan? 19-08-2012 23:11:26 < juergbi!~juerg@77-58-108-244.dclient.hispeed.ch: vala follows gnome releases pretty closely nowadays 19-08-2012 23:11:51 < mpiechotka!~mpiechotk@c-69-181-160-249.hsd1.ca.comcast.net: juergbi: I'm finishing it. I've fixing last 2 bugs before 0.8 (one i s nearly coded right now). 19-08-2012 23:11:53 < juergbi!~juerg@77-58-108-244.dclient.hispeed.ch: so you intend to release libgee 0.8 stable with gnome 3.6 next month? 19-08-2012 23:12:04 < juergbi!~juerg@77-58-108-244.dclient.hispeed.ch: ok, great 19-08-2012 23:12:23 < mpiechotka!~mpiechotk@c-69-181-160-249.hsd1.ca.comcast.net: juergbi: Yes. In the worst case alpha/beta/rc/however you'll call it will be released next week. I guess that means we should go ahead with the patches in bug #673918 and here.
(In reply to comment #8) > I guess that means we should go ahead with the patches in bug #673918 and here. Bzzt. I just talked to the release team, and we’ve decided to stick with libgee 0.6 for GNOME 3.6. folks will be ported to libgee 0.8 at the start of the next cycle. See: https://bugzilla.gnome.org/show_bug.cgi?id=673918#c33
Let's do this for 3.8 then.
any update ? folks seems to be done now
Should be fixed in master: commit 28df2ffe0a5239675deef8cd9624f4cebc08bc32 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Tue Feb 19 11:59:59 2013 +0100 Revert "Go back to libgee 0.6.x" This reverts commit 670aec4ba8b16fbf35afdf65b65c1904872286dc. https://bugzilla.gnome.org/show_bug.cgi?id=680152