GNOME Bugzilla – Bug 680133
BRP Checks: 64bit-portability-issue
Last modified: 2012-09-11 19:32:23 UTC
openSUSE Build Root Policy check triggers those errors when building g-c-c 3.5.5: I: A function uses a 'return;' statement, but has actually a value to return, like an integer ('return 42;') or similar. W: gnome-control-center voidreturn gnome-control-center.c:176 E: gnome-control-center 64bit-portability-issue cc-power-panel.c:617 E: gnome-control-center 64bit-portability-issue gnome-region-panel-input.c:172, 905 (I: Informational / W: Warning / E: Error). The build log excerpts for the error statements are: * for E: gnome-control-center 64bit-portability-issue cc-power-panel.c:617 cc-power-panel.c: In function 'add_device_secondary': cc-power-panel.c:617:3: warning: implicit declaration of function 'gtk_level_bar_new' [-Wimplicit-function-declaration] cc-power-panel.c:617:10: warning: assignment makes pointer from integer without a cast [enabled by default] * for E: gnome-control-center 64bit-portability-issue gnome-region-panel-input.c:172 ### gnome-region-panel-input.c: In function 'fetch_ibus_engines': gnome-region-panel-input.c:172:3: warning: implicit declaration of function 'ibus_bus_get_engines_by_names' [-Wimplicit-function-declaration] gnome-region-panel-input.c:172:11: warning: assignment makes pointer from integer without a cast [enabled by default] * for E: gnome-control-center 64bit-portability-issue gnome-region-panel-input.c:905 gnome-region-panel-input.c: In function 'setup_input_tabs': gnome-region-panel-input.c:905:7: warning: implicit declaration of function 'ibus_bus_new_async' [-Wimplicit-function-declaration] gnome-region-panel-input.c:905:12: warning: assignment makes pointer from integer without a cast [enabled by default] All those kind of warnings are known to cause crashers...
(In reply to comment #0) > * for E: gnome-control-center 64bit-portability-issue cc-power-panel.c:617 > cc-power-panel.c: In function 'add_device_secondary': > cc-power-panel.c:617:3: warning: implicit declaration of function > 'gtk_level_bar_new' [-Wimplicit-function-declaration] > cc-power-panel.c:617:10: warning: assignment makes pointer from integer without > a cast [enabled by default] This one is likely nothing more than the fact that GTK3 is not requested in a high enough version (3.5.8), as GtkLevelBar is a rather new addition, yet configure.ac requires 'only' 3.5.5, thus resulting in the possibility of building g-c-c without a recent enough Gtk+-3.0
Created attachment 219481 [details] [review] Bump Gtk+ required version to 3.5.8 With gtk 3.5.8, the GtkLevelBar is being introduced and power panel requires this.. so let's not build crashing source :)
Review of attachment 219481 [details] [review]: Looks right
Scanning through the code of ibus, it seems the two other implicit declared functions * ibus_bus_get_engines_by_names * ibus_bus_new_async are being added in versions of ibus > 1.4.1 (1.4.1 being the latest release). so likely, we should just require 'newer than 1.4.1' in configure as well? (current git 'identifies' itself as 1.4.99) ? What are your thoughts on that?
(In reply to comment #3) > Review of attachment 219481 [details] [review]: > > Looks right (FYI: I do not have commit access, in case the commit_now was targeted at me.. seen this happening in the past)
Created attachment 219496 [details] [review] 2nd Part of the bug: IBUS needs to be >= 1.4.99 (unstable branch.. 1.4.99.20120712 has a released tarball)
Just to confirm: the errors about ibus_* disappear when building with ibus 1.4.99.
The following fixes have been pushed: c4db04f configure: We require ibus version 1.4.99 or newer (1.5 unstable) f9e052e configure: Bump GTK+ requirement to 3.5.8: first version to bring GtkLevelBar.
Created attachment 219578 [details] [review] configure: We require ibus version 1.4.99 or newer (1.5 unstable)
Created attachment 219579 [details] [review] configure: Bump GTK+ requirement to 3.5.8: first version to bring GtkLevelBar.
Created attachment 219617 [details] [review] fix build with --disable-ibus The ibus version check is placed in the wrong place and breaks the build with --disable-ibus
Review of attachment 219617 [details] [review]: Oh, looks right indeed. Thanks
Comment on attachment 219617 [details] [review] fix build with --disable-ibus Last patch got committed: http://git.gnome.org/browse/gnome-control-center/commit/configure.ac?id=fbe6756c6f2104d78854da927b96c3d88cd31a2e