After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680105 - Applying aspect ratio makes touch device very slow
Applying aspect ratio makes touch device very slow
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: wacom
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-17 15:43 UTC by Olivier Fourdan
Modified: 2012-07-17 16:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch to avoid the issue with touch devices (2.85 KB, patch)
2012-07-17 15:43 UTC, Olivier Fourdan
none Details | Review
Updated patch (2.85 KB, patch)
2012-07-17 15:59 UTC, Olivier Fourdan
none Details | Review
Updated patch (3.02 KB, patch)
2012-07-17 16:00 UTC, Olivier Fourdan
none Details | Review

Description Olivier Fourdan 2012-07-17 15:43:42 UTC
Created attachment 219029 [details] [review]
proposed patch to avoid the issue with touch devices

Both calibration and aspect ratio use the "area" parameter of the device, but on the same hardware, stylus and touch part may not have the same resolution:

    $xsetwacom --get "Wacom Intuos5 touch M Finger touch"  Area
    0 0 4096 4096

    $ xsetwacom --get "Wacom Intuos5 touch M Pen stylus"  Area
    0 0 44704 27940

Therefore applying the area computed on the stylus on the touch device makes it very slow (almost unusable).

The proposed patch avoid applying the area on touch devices, these are normally set to relative mode so aspect ratio does not make sense there either.
Comment 1 Olivier Fourdan 2012-07-17 15:59:11 UTC
Created attachment 219031 [details] [review]
Updated patch

Adds a comment for why we ignore touch devices when setting area.
Comment 2 Olivier Fourdan 2012-07-17 16:00:27 UTC
Created attachment 219032 [details] [review]
Updated patch

Really add the comment...
Comment 3 Olivier Fourdan 2012-07-17 16:02:05 UTC
Note: This patch applies on top of the patch for bug 680105
Comment 4 Olivier Fourdan 2012-07-17 16:03:26 UTC
err, I meant this patch applies on top of the patch for bug 677095
Comment 5 Olivier Fourdan 2012-07-17 16:41:46 UTC
Committed.