GNOME Bugzilla – Bug 680100
should load default background if the user settings is invalid
Last modified: 2012-07-18 09:17:23 UTC
Not sure if that would count as a behaviour change of the API but it would be nice if gnome_bg_load_from_preferences() would fallback to load the default wallpaper if the currently configured one is not available. It would be useful in case where the wallpaper in use by the user would get deleted for example. Using g_settings_get_mapped() would make that fallback easy
Created attachment 219023 [details] [review] load the default background if the configured one is invalid
Created attachment 219025 [details] [review] load the default background if the configured one is invalid
Created attachment 219026 [details] [review] load the default background if the configured one is invalid ups, I renamed the function in the previous diff and of course forgot one instance, that one should build and work fine
Review of attachment 219026 [details] [review]: Hmm...but do we actually support non-local backgrounds? If not, why is the config option a URI? The code looks correct aside from that question.
Good question, I'm not sure how you would set a remote background from GNOME since the background panel does copy user added images locally... Note that I didn't add any new check there, the code I use in bg_gsettings_mapping() is basically the current trunk code from gnome_bg_load_from_preferences() moved
(In reply to comment #5) > Good question, I'm not sure how you would set a remote background from GNOME > since the background panel does copy user added images locally... Right; probably making it a URI was someone trying to be forward-thinking or something. > Note that I didn't add any new check there, the code I use in > bg_gsettings_mapping() is basically the current trunk code from > gnome_bg_load_from_preferences() moved Ok; feel free to commit, thanks!
thanks, commited to trunk: http://git.gnome.org/browse/gnome-desktop/commit/?id=6deb007f102d8ae9eabb10808f34d7129932dad3