After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680089 - libsoup-2.39.4: tld-parser.py mixes tabs and spaces
libsoup-2.39.4: tld-parser.py mixes tabs and spaces
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
2.39.x
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2012-07-17 12:09 UTC by Albert Hopkins
Modified: 2012-07-17 12:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tld-parser.py patch for libsoup-gnome (932 bytes, patch)
2012-07-17 12:17 UTC, Albert Hopkins 		none Details | Review

Description Albert Hopkins 2012-07-17 12:09:42 UTC 
I get the following build error when compiling libsoup:

---

make[2]: Entering directory `/var/tmp/portage/net-libs/libsoup-2.39.4/work/libsoup-2.
39.4/libsoup'
./tld-parser.py ../data/effective_tld_names.dat tld_data.inc
  GEN    soup-marshal.list
  GEN    soup-enum-types.c
  GEN    soup-enum-types.h

+ Trace 230520

  • File "./tld-parser.py", line 35 
    inc_file.write(',\n')
TabError: inconsistent use of tabs and spaces in indentation 
make[2]: *** [tld_data.inc] Error 1
make[2]: *** Waiting for unfinished jobs....
  GEN    soup-marshal.c
  GEN    soup-marshal.h
---

The attached patch fixes this by using only spaces (and also removes an unused import).
Comment 1 Albert Hopkins 2012-07-17 12:17:25 UTC 
Created attachment 219013 [details] [review]
tld-parser.py patch for libsoup-gnome

Same for libsoup-gnome.
Comment 2 Dan Winship 2012-07-17 12:29:22 UTC 
Thanks. I guess this is a python 3 thing? (I don't get an error with
python 2.6...)