GNOME Bugzilla – Bug 680055
epiphany segfault after freeing the list twice. Fix setting the list to null after free.
Last modified: 2012-07-16 22:10:43 UTC
(epiphany:14909): GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed backtrace:
+ Trace 230518
after two of those errors ends up in a segfault. I fixed it by setting priv->decoders to NULL after freeing this list. The issue appeared after : commit b3b7df0c0beea646479be468b888becce5336c87 Author: Dan Winship <danw@gnome.org> Date: Mon Jul 2 09:49:48 2012 -0400 Use g_slist_free_full() The previous code was doing : while (priv->decoders) { g_object_unref (priv->decoders->data); priv->decoders = g_slist_delete_link (priv->decoders, priv->decoders); } => priv->decoders = g_slist_delete_link (priv->decoders, priv->decoders); was setting the list to NULL as the last item was NULL and ended up assigned to priv->decoders.
Created attachment 218949 [details] [review] Set the message priv->decoders to NULL after free
huh. wonder why it didn't crash in the tests for me? thanks for the patch!
*** Bug 680015 has been marked as a duplicate of this bug. ***