After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680001 - missing Back button from a collection when previewing a doc
missing Back button from a collection when previewing a doc
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
0.5.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-07-16 12:46 UTC by Anna Zacchi
Modified: 2012-09-12 21:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
toolbar: add back button if required when populating (1.34 KB, patch)
2012-09-12 09:07 UTC, Volker Sobek (weld)
committed Details | Review

Description Anna Zacchi 2012-07-16 12:46:33 UTC
When you enter a collection and then preview a file, when you go back from the file preview to the collection, the back button is missing. So you are stuck inside the collection and cannot go back to the main overview anymore.
Comment 1 Volker Sobek (weld) 2012-09-12 09:07:01 UTC
Created attachment 224077 [details] [review]
toolbar: add back button if required when populating

I also wrote a separate patch for bug #680000, to allow navigating back in nested collections, but it's based on this patch, because it replaces Global.collectionManager.setActiveItem() by another method to go back in history, so I'll first wait and see if this patch here passes.
Comment 2 Cosimo Cecchi 2012-09-12 21:34:11 UTC
Attachment 224077 [details] pushed as f47d4fe - toolbar: add back button if required when populating

Thanks for the patch, looks and works great! I pushed a slightly modified version that merges the code you added with the one already existing in _onActiveCollectionChanged().