After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679996 - [PATCH] gobject docs minor cleanup
[PATCH] gobject docs minor cleanup
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other All
: Normal trivial
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-07-16 10:08 UTC by David Röthlisberger
Modified: 2012-08-06 14:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] gobject docs: Remove incorrect reference to signals docs (1.24 KB, patch)
2012-07-16 10:09 UTC, David Röthlisberger
accepted-commit_now Details | Review
[PATCH] gobject docs: Remove confusing acronym (1.36 KB, patch)
2012-07-16 12:13 UTC, David Röthlisberger
accepted-commit_now Details | Review
gobject docs: Remove confusing acronym (1.40 KB, patch)
2012-08-06 14:28 UTC, Matthias Clasen
committed Details | Review
gobject docs: Remove incorrect reference to signals docs (1.29 KB, patch)
2012-08-06 14:28 UTC, Matthias Clasen
committed Details | Review

Description David Röthlisberger 2012-07-16 10:08:33 UTC
The chapter on signals[1] comes after this chapter[2], not before (see the table of contents[3]).

[1] http://developer.gnome.org/gobject/unstable/chapter-signal.html
[2] http://developer.gnome.org/gobject/unstable/chapter-gobject.html
[3] http://developer.gnome.org/gobject/unstable/index.html
Comment 1 David Röthlisberger 2012-07-16 10:09:30 UTC
Created attachment 218900 [details] [review]
[PATCH] gobject docs: Remove incorrect reference to signals docs
Comment 2 David Röthlisberger 2012-07-16 12:13:49 UTC
Created attachment 218905 [details] [review]
[PATCH] gobject docs: Remove confusing acronym

In the wikipedia disambiguation page[1] the only entry that even
remotely makes sense in this context is "and so on". Google searches
for "aso memory management" and "aso garbage collection" don't yield
anything relevant.

[1] http://en.wikipedia.org/wiki/ASO
Comment 3 Emmanuele Bassi (:ebassi) 2012-07-16 16:50:13 UTC
Review of attachment 218905 [details] [review]:

looks good
Comment 4 Emmanuele Bassi (:ebassi) 2012-07-16 16:50:54 UTC
Review of attachment 218900 [details] [review]:

looks good
Comment 5 David Röthlisberger 2012-07-20 09:54:03 UTC
Emmanuele: Could you commit the patches for me? I don't have commit access. Thanks!
Comment 6 Matthias Clasen 2012-08-06 14:28:39 UTC
The following fixes have been pushed:
be70959 gobject docs: Remove confusing acronym
bcda26a gobject docs: Remove incorrect reference to signals docs
Comment 7 Matthias Clasen 2012-08-06 14:28:41 UTC
Created attachment 220451 [details] [review]
gobject docs: Remove confusing acronym

In the wikipedia disambiguation page[1] the only entry that even
remotely makes sense in this context is "and so on". Google searches
for "aso memory management" and "aso garbage collection" don't yield
anything relevant.

[1] http://en.wikipedia.org/wiki/ASO
Comment 8 Matthias Clasen 2012-08-06 14:28:43 UTC
Created attachment 220452 [details] [review]
gobject docs: Remove incorrect reference to signals docs

The chapter on signals comes after this chapter, not before (see
"tut_gobject.xml" in docs/reference/gobject/gobject-docs.xml).