After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679994 - Added buffer-list support in rtph264pay
Added buffer-list support in rtph264pay
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2012-07-16 09:26 UTC by Patricia Muscalu
Modified: 2012-07-17 14:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Added buffer-list support in rtph264pay (10.44 KB, patch)
2012-07-16 09:26 UTC, Patricia Muscalu
none Details | Review
Use buffer lists per default (9.03 KB, patch)
2012-07-16 13:47 UTC, Patricia Muscalu
none Details | Review

Description Patricia Muscalu 2012-07-16 09:26:08 UTC
Created attachment 218894 [details] [review]
Added buffer-list support in rtph264pay

Currently there is no buffer-list support rtph264pay.
Comment 1 Wim Taymans 2012-07-16 09:31:15 UTC
We can remove the buffer-list option and just always enable buffer-lists, IMO. The fallback option for buffer-lists does not cause any memcpy anymore and the different memory blocks on buffers is something that all elements should handle gracefully.
Comment 2 Patricia Muscalu 2012-07-16 13:47:08 UTC
Created attachment 218912 [details] [review]
Use buffer lists per default
Comment 3 Wim Taymans 2012-07-17 08:11:06 UTC
commit d38ac43a275c718a9081be5b883193ababb9f217
Author: Patricia Muscalu <>
Date:   Mon Jul 16 11:07:44 2012 +0200

    rtph264pay: use buffer lists
Comment 4 Wim Taymans 2012-07-17 08:12:14 UTC

There are still some memcpy in the base class when the memory is merged to change the RTP header. I will see if that can be fixed.
Comment 5 Wim Taymans 2012-07-17 14:47:52 UTC
commit 11a494d5c966148c61929d5d887df3d0815f3021
Author: Wim Taymans <>
Date:   Tue Jul 17 16:35:06 2012 +0200

    rtp: Add support for multiple memory blocks in RTP
    Add support RTP buffers with multiple memory blocks. We allow one block for the
    header, one for the extension data, N for data and one memory block for the
    Remove the validate function, we validate now when we map because we need to
    parse things in order to map multiple memory blocks.