After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679968 - Add some annotations to GBytes, GVariantType and GTimeZone.
Add some annotations to GBytes, GVariantType and GTimeZone.
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: docs
2.33.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-07-15 17:33 UTC by Krzesimir Nowak
Modified: 2017-04-04 08:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Adds some annotations to GVariantType. (1.33 KB, patch)
2012-07-15 17:33 UTC, Krzesimir Nowak 		committed Details | Review
Adds some annotations to GBytes. (830 bytes, patch)
2012-07-15 17:34 UTC, Krzesimir Nowak 		reviewed Details | Review
Adds some annotations to GTimeZone. (1.60 KB, patch)
2012-07-15 17:35 UTC, Krzesimir Nowak 		reviewed Details | Review
Make GTimeZone a boxed type. (2.58 KB, patch)
2012-07-28 16:14 UTC, Krzesimir Nowak 		committed Details | Review

Description Krzesimir Nowak 2012-07-15 17:33:43 UTC 
Created attachment 218862 [details] [review]
Adds some annotations to GVariantType.

Patches follow.
Comment 1 Krzesimir Nowak 2012-07-15 17:34:18 UTC 
Created attachment 218863 [details] [review]
Adds some annotations to GBytes.
Comment 2 Krzesimir Nowak 2012-07-15 17:35:07 UTC 
Created attachment 218864 [details] [review]
Adds some annotations to GTimeZone.
Comment 3 Colin Walters 2012-07-15 21:20:02 UTC 
Review of attachment 218863 [details] [review]:

It's more that we don't bother processing the return value because it's a raw pointer, and those get marked as introspectable=0, so not available to bindings.

Why do you want this?
Comment 4 Colin Walters 2012-07-15 21:21:24 UTC 
Review of attachment 218864 [details] [review]:

Why not make it boxed?  Add it to gobject/glib-types.h
Comment 5 Colin Walters 2012-07-15 21:22:08 UTC 
Review of attachment 218862 [details] [review]:

Ok.
Comment 6 Krzesimir Nowak 2012-07-16 15:45:09 UTC 
First things first: I'd like to have those annotations fixed, because my gmmproc rewrite (which uses .gir files as a source of API information) chokes when some of them are missing in .gir (like transfers in return values) for the API entities that are wrapped.

gmmproc is a C++ source code generator that is used mainly by C++ bindings like glibmm or gtkmm.

(In reply to comment #3)
> Review of attachment 218863 [details] [review]:
> 
> It's more that we don't bother processing the return value because it's a raw
> pointer, and those get marked as introspectable=0, so not available to
> bindings.
> 
> Why do you want this?
GBytes is partially wrapped in glibmm (http://git.gnome.org/browse/glibmm/diff/glib/src/bytes.hg?id=2d760935013ed77eec2b225643536af0d37d175e). If this fix is incorrect, then I can of course wrap this function manually.

(In reply to comment #4)
> Review of attachment 218864 [details] [review]:
> 
> Why not make it boxed?  Add it to gobject/glib-types.h

I can check if it will work.
Comment 7 Krzesimir Nowak 2012-07-28 16:14:22 UTC 
Created attachment 219793 [details] [review]
Make GTimeZone a boxed type.

Attached a patch making GTimeZone a boxed type. That indeed makes annotating GTimeZone's constructors not necessary.
Comment 8 Philip Withnall 2017-04-04 08:56:20 UTC 
Review of attachment 218863 [details] [review]:

A very similar patch was pushed as 1e1e6c1086a494f065313dba73f7ab04078b8185, via bug #755961.
Comment 9 Philip Withnall 2017-04-04 08:56:43 UTC 
So this can be closed.