After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679966 - world-3.6: declare NetworkManager vala dependency
world-3.6: declare NetworkManager vala dependency
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2012-07-15 17:01 UTC by Allison Karlitskaya (desrt)
Modified: 2012-07-15 17:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
world-3.6: declare NetworkManager vala dependency (1000 bytes, patch)
2012-07-15 17:01 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2012-07-15 17:01:37 UTC
See patch (and commit message).
Comment 1 Allison Karlitskaya (desrt) 2012-07-15 17:01:39 UTC
Created attachment 218861 [details] [review]
world-3.6: declare NetworkManager vala dependency

If NetworkManager tries to build against the system valac and it's too
old, the build fails (due to missing bindings).

Declare a valac dependency so that we make sure the new Vala is
installed before we attempt to build NetworkManager.
Comment 2 Colin Walters 2012-07-15 17:04:53 UTC
Review of attachment 218861 [details] [review]:

Looks fine.  (But I'm still curious if something is depending on the NM vala bindings).
Comment 3 Allison Karlitskaya (desrt) 2012-07-15 17:07:14 UTC
Attachment 218861 [details] pushed as e422e44 - world-3.6: declare NetworkManager vala dependency