GNOME Bugzilla – Bug 679925
Space bar should fill available space
Last modified: 2021-07-05 14:35:52 UTC
Created attachment 218808 [details] screenshot It looks strange having a gap in the keyboard layout. It would also be better if the space key was more centred.
Created attachment 221777 [details] [review] keyboard: respect "center" alignment of keys
Created attachment 221778 [details] Screenshot after the patch is applied
verify the patch, space key is in middle . Working on my machine
Review of attachment 221777 [details] [review]: Looks fine with that fix ::: js/ui/keyboard.js @@ +364,3 @@ + center_box.add(button.actor); + break; + case 'right': Feel like we should have a 'default:' case here just to be a bit safer.
Comment on attachment 221777 [details] [review] keyboard: respect "center" alignment of keys Thanks for the review, added the 'default' case. Since the patch only addresses the centering issue, I keep the bug open. Attachment 221777 [details] pushed as 32e8a9b - keyboard: respect "center" alignment of keys
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/ Thank you for your understanding and your help.