GNOME Bugzilla – Bug 679868
[New roster] The Top Contacts group name isn't displayed above the top contacts if all of them are offline
Last modified: 2012-07-23 07:20:05 UTC
Created attachment 218737 [details] Screenshot of the problem It should be displayed instead of having only the contacts lost on the top of the list. Screenshot of the problem (in test-empathy-roster-view but it was the same situation in empathy too) attached.
Created attachment 218738 [details] [review] Display the Top Contacts group name above the top contacts even if all of them are offline
Review of attachment 218738 [details] [review]: That's not the right way to fix this. With your patch you'll display offline favorite contacts in all their group, not only the top one, which is not the intented behaviour (see the comment above). I think the right way is to move the top group logic from filter_contact() to contact_should_be_displayed(). I should be something like this: if (favorite) { if (!show_groups) /* Always display favourite contacts in non-group mode..... */ return TRUE; else /* Always display fav contact in group mode only in the 'top group'/ if (contact_group_name == TOP) return TRUE; }
Created attachment 218893 [details] [review] Display the Top Contacts group name above the top contacts even if all of them are offline
Review of attachment 218893 [details] [review]: ::: libempathy-gtk/empathy-roster-view.c @@ +832,3 @@ + + if (tp_strdiff (group_name, EMPATHY_ROSTER_VIEW_GROUP_TOP_GROUP)) + /* Always display favourite contact in group mode only in the We don't want to return FALSE here; with your patch fav contact will only appear in the top group now. We should just continue the normal flow of the function if that's another group.
Created attachment 218969 [details] [review] Display the Top Contacts group name above the top contacts even if all of them are offline
Created attachment 218996 [details] [review] Display the Top Contacts group name above the top contacts even if all of them are offline
Review of attachment 218996 [details] [review]: Looks good, thanks.
Attachment 218996 [details] pushed as a507ac4 - Display the Top Contacts group name above the top contacts even if all of them are offline
Created attachment 219422 [details] [review] empathy-roster-model-manager.c: implement empathy_roster_model_manager_get_individuals ()
Review of attachment 219422 [details] [review]: Wrong bug number