After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679847 - portability: use /bin/sh instead of /bin/bash
portability: use /bin/sh instead of /bin/bash
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.4.x
Other OpenBSD
: Normal trivial
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-13 11:55 UTC by Antoine Jacoutot
Modified: 2012-07-15 08:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use /bin/sh instead of /bin/bash (769 bytes, patch)
2012-07-13 11:55 UTC, Antoine Jacoutot 		accepted-commit_now Details | Review

Description Antoine Jacoutot 2012-07-13 11:55:27 UTC 
Created attachment 218704 [details] [review]
use /bin/sh instead of /bin/bash

Hi.

There is nothing requiring bash specific features in the gnome-shell-extension-prefs script, so just use /bin/sh which is portable amongst all Unices.

Would that be alright to push?
Comment 1 drago01 2012-07-14 18:22:33 UTC 
Review of attachment 218704 [details] [review]:

Looks fine, make sure to add a bug reference to the commit message before pushing (or use git-bz).
Comment 2 Antoine Jacoutot 2012-07-15 08:19:20 UTC 
(In reply to comment #1)
> Review of attachment 218704 [details] [review]:
> 
> Looks fine, make sure to add a bug reference to the commit message before
> pushing (or use git-bz).

Thank you.
3df3f0d9dc0527a3d5096c0118a2bf869a035f30