After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679845 - crash on OpenBSD: needs _XOPEN_SOURCE_EXTENDED for strptime(3)
crash on OpenBSD: needs _XOPEN_SOURCE_EXTENDED for strptime(3)
Status: RESOLVED FIXED
Product: gnome-system-log
Classification: Core
Component: general
git master
Other OpenBSD
: Normal critical
: ---
Assigned To: gnome-system-log-maint
gnome-system-log-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-13 10:25 UTC by Antoine Jacoutot
Modified: 2012-07-16 21:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add a define for _XOPEN_SOURCE_EXTENDED (822 bytes, patch)
2012-07-13 10:25 UTC, Antoine Jacoutot 		committed Details | Review

Description Antoine Jacoutot 2012-07-13 10:25:56 UTC 
Created attachment 218698 [details] [review]
add a define for _XOPEN_SOURCE_EXTENDED

Hi.

strptime(3) was introduced in XPG4.
On OpenBSD, just defining _XOPEN_SOURCE gets you the older XPG3 wich doesn't
include strptime(3).
To get XPG4, you'll have to add #define _XOPEN_VERSION 4, but doing that may
cause some issues.  So it is probably better to just ask for XPG4v2 by adding
#define _XOPEN_SOURCE_EXTENDED 1.

This actually fix a runtime crash on OpenBSD when starting
gnome-system-log.

Thoughts?
Comment 1 Cosimo Cecchi 2012-07-13 21:24:32 UTC 
Review of attachment 218698 [details] [review]:

It looks fine to me, but does this have any other implications on Linux?
Comment 2 Antoine Jacoutot 2012-07-13 21:31:38 UTC 
(In reply to comment #1)
> Review of attachment 218698 [details] [review]:
> 
> It looks fine to me, but does this have any other implications on Linux?

Nope :-)

Same patch was committed in evolution-data-server, eog and gthumb.
https://bugzilla.gnome.org/show_bug.cgi?id=676462
https://bugzilla.gnome.org/show_bug.cgi?id=676461
https://bugzilla.gnome.org/show_bug.cgi?id=676108
Comment 3 Cosimo Cecchi 2012-07-16 21:00:43 UTC 
Thanks, I pushed this to master for today's 3.5.4 release.