After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679844 - Windows are not properly closed when quitting from the shell menu
Windows are not properly closed when quitting from the shell menu
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-13 09:42 UTC by Carlos Garcia Campos
Modified: 2012-09-27 08:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (7.49 KB, patch)
2012-07-13 09:43 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2012-07-13 09:42:47 UTC 
This have several side effects. Ephy will exit even if there are ongoing downloads or modified unsubmitted forms. EphyWindow won't be destroyed so dispose and finalize methods won't be called.
Comment 1 Carlos Garcia Campos 2012-07-13 09:43:31 UTC 
Created attachment 218695 [details] [review]
Patch
Comment 2 Xan Lopez 2012-08-13 15:03:19 UTC 
Comment on attachment 218695 [details] [review]
Patch

This looks OK, just one thought: any reason why we should not make ephy_window_close destroy the window if it's going to return TRUE?
Comment 3 Carlos Garcia Campos 2012-08-14 15:03:06 UTC 
Not that I remember, so I guess we can make ephy_window_close destroy the window and simplify ephy_session_close_all_windows.
Comment 4 Carlos Garcia Campos 2012-08-16 07:07:45 UTC 
Ok, now I remember why. ephy_window_close() is also called from delete_event callback. When delete_event callback returns FALSE the event is propagated and the default handler destroys the widget.
Comment 5 Xan Lopez 2012-09-24 16:38:25 UTC 
Comment on attachment 218695 [details] [review]
Patch

OK, I guess it makes sense, although I'm not totally sure it's OK make the method do thing slike this just because it's called from the delete-event handler.
Comment 6 Carlos Garcia Campos 2012-09-25 08:01:46 UTC 
I guess you mean commit_after_freeze :-) Thanks for the review.
Comment 7 Carlos Garcia Campos 2012-09-27 08:17:02 UTC 
Comment on attachment 218695 [details] [review]
Patch

Pushed to git master now that we have branched