GNOME Bugzilla – Bug 679836
cc-common-language: A few fixes
Last modified: 2013-01-11 17:51:53 UTC
Just a few things I noticed while stealing the code for g-i-s.
Created attachment 218673 [details] [review]
cc-common-language: Fix memory leaks
Created attachment 218674 [details] [review]
cc-common-language: Use standard translations for language names
Review of attachment 218673 [details] [review]:
Review of attachment 218674 [details] [review]:
This is broken, even after fixing the code to compile, it doesn't show anything in the region panel.
@@ +515,3 @@
+ char *name)
+ if (gdm_language_has_translations (locale_id))
cc-common-language.c: In function 'add_language':
cc-common-language.c:517:44: error: 'locale_id' undeclared (first use in this function)
cc-common-language.c:517:44: note: each undeclared identifier is reported only once for each function it appears in
@@ +530,2 @@
/* Add some common languages first */
+ add_language (ht, "en_US.utf8");
gdm_language_has_translations will fail for the locale with the encoding at the end.
Jasper, will the patch be updated?
Probably not, as it's not that important. The long way isn't too bad.