After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679810 - Adwaita dark theme glitches
Adwaita dark theme glitches
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK3 theme
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-12 16:58 UTC by Tobias Wolf
Modified: 2012-07-21 17:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
composite Screenshot describing the glitches in the dark variant of Adwaita (499.17 KB, image/png)
2012-07-12 16:58 UTC, Tobias Wolf
Details

Description Tobias Wolf 2012-07-12 16:58:28 UTC
Created attachment 218648 [details]
composite Screenshot describing the glitches in the dark variant of Adwaita

I’ve been using the dark variant of Adwaita desktop-wide for a while because I find it looks fantastic.

I have identified about ten glitches with the dark theme that I didn’t report before because I thought the bug would be rejected due to gtk-application-prefer-dark-theme=1 being unsupported. But now the setting has been added to gnome-tweak-tool.

I’ve labeled the problems in the attached composite screenshot. Please advise if this is the proper format for a bug report.
Comment 1 Tobias Wolf 2012-07-12 17:02:19 UTC
There’s also problems with the gnome-contacts background, and the background in the evolution Send/Receive dialog.
Comment 2 Tobias Mueller 2012-07-12 17:11:04 UTC
Hey Tobias :)

Thanks for the nice bug report. Ideally though, we have one bug report per issue. So 'd be cool if you could create separate bug reports  with separate screenshots. Thanks in advance!
Comment 3 Tobias Wolf 2012-07-12 17:36:08 UTC
Ok, if Cosimo says this is necessary I’ll do it.
Comment 4 Cosimo Cecchi 2012-07-16 15:57:17 UTC
Hey Tobias, thanks for the report. I fixed the floating bar borders and the nautilus desktop icon fg colors and border bugs in git master now.

- the Evolution fg color for HTML mails should be filed against Evolution, we are not doing anything special there
- the Nautilus search bar has been changed in git master, so that's not a problem anymore
- I can't reproduce the nautilus sidebar border issue with git master of everything; I suspect an outdated theme/GTK or some weird interaction with the Ubuntu custom scrollbars
- don't know about the change for message colors, but any proposal should be based on the Tango palette [1] (I don't think yours is, but I my eyes might be wrong :) and should go into a separate bug request
- same thing about 0px window borders...we should probably try it and see if it works well enough in different scenarios/applications, but it should be a matter for a separate bug report

Closing this as FIXED.

[1] http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines
Comment 5 André Klapper 2012-07-16 16:31:48 UTC
(In reply to comment #4)
> - the Evolution fg color for HTML mails should be filed against Evolution

In case you plan to file a separate ticket, please include information if that specific HTML message uses CSS for defining colors. If it does, please retest with unstable experimental Evolution version 3.5.x if possible.
CSS has never been supported before version 3.5 (which now uses WebKit instead of ancient GtkHtml for rendering HTML messages).
Also please include your color setting under "Edit > Preferences > Mail Preferences > General > Message Display > Highlight quotations with color".
Comment 6 Tobias Wolf 2012-07-16 16:47:37 UTC
Thanks, Cosimo.

Follow-ups:

Bug #679404 - Evolution: Renders black text in HTML mail
Bug #680030 - Adwaita metacity-3.xml: Remove cosmetic window border
Bug #680031 - Nautilus: Sidebar top border on backdrop window
Bug #680032 - Adwaita: Info bar colors are perceptually grating in dark theme
Bug #680033 - Gnome Contacts need theming for dark variant
Bug #680034 - Evolution Send/Receive dialog has a strange background
Bug #680035 - Tab background in dark theme is wrong/unthemed 


An off-topic remark: Changing type-ahead in Nautilus from jump-to & highlight to folder search is a super bad idea. How do I fight this?
Comment 7 Tobias Wolf 2012-07-16 16:53:27 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > - the Evolution fg color for HTML mails should be filed against Evolution
> 
> In case you plan to file a separate ticket, please include information if that
> specific HTML message uses CSS for defining colors. If it does, please retest
> with unstable experimental Evolution version 3.5.x if possible.
> CSS has never been supported before version 3.5 (which now uses WebKit instead
> of ancient GtkHtml for rendering HTML messages).
> Also please include your color setting under "Edit > Preferences > Mail
> Preferences > General > Message Display > Highlight quotations with color".

Too late. 

I tested 3.5.3 and there is no css in the message, just old-skool HTML. The email headers are also black.

I cannot determine the quoting color because the new color choosing widget is super-dysfunctional. There’s no way to see what the selected color was. Another thing that was broken and fell by the wayside because in modern day Gnome a user with an insight is ignored. I cannot even use an eye dropper from that dialog on the swatch, because the eye dropper was also removed. I filed this before. Anyway, it’s light gray.
Comment 8 André Klapper 2012-07-16 18:04:26 UTC
(In reply to comment #7)
> I cannot determine the quoting color because the new color choosing widget is
> super-dysfunctional. There’s no way to see what the selected color was.

The chosen color should have a checkmark displayed, like here:
http://library.gnome.org/misc/release-notes/3.4/figures/rnusers.color-chooser.png.en

If it does not, a new bug report with steps to reproduce the problem that you see plus a screenshot are welcome.
Comment 9 Tobias Wolf 2012-07-16 18:23:11 UTC
André, if you look at my screenshot in bug #679404, the chosen color has a checkmark, it is a custom color. 

The problem is, there’s no way to report the color because there’s no way anymore to read the tristimulus values of the color. I can only report "gray", but not which gray.

This is bad for a general purpose color chooser.
Comment 10 Cosimo Cecchi 2012-07-16 18:48:07 UTC
(In reply to comment #9)
> André, if you look at my screenshot in bug #679404, the chosen color has a
> checkmark, it is a custom color. 
> 
> The problem is, there’s no way to report the color because there’s no way
> anymore to read the tristimulus values of the color. I can only report "gray",
> but not which gray.
> 
> This is bad for a general purpose color chooser.

This is not really the right place for this discussion, but did you know you can right click on any of those colors to get a plane and a range with its HSV representation? You can also right click on the saturation/value plane, or on the hue range to get the value detail (and some spinbuttons for fine adjustment).
Comment 11 Tobias Wolf 2012-07-16 18:57:33 UTC
Oooh, I didn’t know that. I didn’t expect that you can right click anything. So with a bit of artistic right clicking I can find out HSV and hex. But if you click in the wrong location the plane cursor gets shifted and it displays another value. But no RGB tristimulus.

TBH, nowadays I just expect things get removed never to be seen again  (this reminds me of the book »Momo«), so I didn’t try right-clicking. Thanks for the info.
Comment 12 Dmitry Shachnev 2012-07-21 17:29:10 UTC
See also bug 680382 for issues with Epiphany.