GNOME Bugzilla – Bug 679805
minor introspection typo fixes (?)
Last modified: 2012-08-24 19:17:17 UTC
Created attachment 218640 [details] [review] introspection fixes Besides two obvious typos, I've added '(scope call):' in three places. I'm not sure if that's the correct value, but the descriptions of those functions would suggest so. On unrelated note: during build I see: vtebg.c: In function 'vte_bg_cache_item_free': vtebg.c:282:5: warning: dereferencing type-punned pointer will break strict-aliasing rules vtebg.c: In function 'vte_bg_cache_add': vtebg.c:342:8: warning: dereferencing type-punned pointer will break strict-aliasing rules now, it's just an idea, but it seems that removing those casts and changing the type of that structure field from 'GdkPixbuf*' to 'void*' silences the warnings - not sure if that proper though. I'm also not quite sure how to go about: vteaccess.c: In function 'vte_terminal_accessible_finalize': vteaccess.c:974:11: warning: dereferencing type-punned pointer will break strict-aliasing rules On the other hand vteaccess.c: In function 'vte_terminal_accessible_get_index_in_parent': vteaccess.c:2289:7: warning: declaration of 'index' shadows a global declaration might just be a complaint about 'char *index(const char *s, int c);' from strings.h - just a guess though.
Just ignore those compiler erros. Patch looks ok, please commit to vte-0-34 and vte-next branches (will have to adapt a bit to vte-next).
Ping ? Do you have a gnome git account and can commit yourself?
*** Bug 680824 has been marked as a duplicate of this bug. ***
(In reply to comment #2) > Ping ? Do you have a gnome git account and can commit yourself? If I had an account, I'd press much harder in regard of bug 513812 (and investigated bug 679630 properly by now). I just lurk around and every now and then try to make correct guesses.
Jeez, not that bug again :))
Alright. Attach a git format-patch formatted patch against vte-0-34 branch, and I'll commit for you.
Created attachment 221054 [details] [review] updated patch (no functional differences) Other than the offsets, there's no difference between the file I initially attached and a patch against current vte-0-34 HEAD.
That's not a git format-patch patch that can be git-am'd ...
Fixed on 0-34 and next. Next time, please do use git format-patch.