GNOME Bugzilla – Bug 679790
Add support for allocating BSD PTYs through openpty(3)
Last modified: 2012-07-13 14:52:51 UTC
Created attachment 218613 [details] [review] Diff implementing the openpty support The diff attached allow systems like OpenBSD, that does not implement the Unix98 PTY family of functions, to allocate the pseudo-tty required for the ssh authentication using the openpty(3) BSD function. It is similar to the VTE diff [0] I submitted some months ago and has been committed to the OpenBSD ports tree. [0] https://bugzilla.gnome.org/show_bug.cgi?id=670758
I can confirm this diff works beautifully on several OpenBSD+GNOME installations I use here. It's also enabled by default in our gvfs package. I would love to be able to push this.
Review of attachment 218613 [details] [review]: Thanks for the patch, it looks good to me, most of the functionality is ifdef'ed anyway. The code is basically shared with other components and duplicated, if it works in vte, I assume it'll work fine in gvfs.
Committed in master: commit 2fec402d6523e4cf416d754f69d012dc67a58a2e Author: Martin Pieuchot <mpi@openbsd.org> Date: Fri Jul 13 16:51:39 2012 +0200 daemon: Support allocating PTYs through openpty on BSD Allows systems supporting the BSD openpty(3) utily function but not the Unix98 PTY function family (grantpt(3), unlockpt(3), ...) to allocate a pseudo-tty required for the ssh authentication. https://bugzilla.gnome.org/show_bug.cgi?id=679790 Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>