After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679684 - Don't use SoupCache when building with WebKit2
Don't use SoupCache when building with WebKit2
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
git master
Other Linux
: Normal normal
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2012-07-10 13:39 UTC by Carlos Garcia Campos
Modified: 2012-08-03 07:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.97 KB, patch)
2012-07-10 16:43 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2012-07-10 13:39:49 UTC 
The code is not #ifdefed because it builds, but it's not used, and in case of being issue it might crash, because the cache object will be NULL. The only thing that needs to be ported for now is ephy_embed_single_clear_cache(), but it requires WebKit API not landed yet. See

https://bugs.webkit.org/show_bug.cgi?id=90797
https://bugs.webkit.org/show_bug.cgi?id=90856
Comment 1 Carlos Garcia Campos 2012-07-10 16:43:01 UTC 
Created attachment 218445 [details] [review]
Patch

WebKit patch adding api to clear the cache landed already. Disk cache implementation didn't land yet, so this will automatically work when it lands. For now it's safe to apply this patch that should also fix a crash if the clear button is pressed in wk2.
Comment 2 Xan Lopez 2012-08-01 17:50:18 UTC 
Review of attachment 218445 [details] [review]:

OK.